Package Delivery Expansion #20003
Open
Package Delivery Expansion #20003
69
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Geevies
commented
Oct 5, 2024
Geevies
commented
- Cargo delivery packages now have colored tags on them which should hopefully make it easier to distinguish between them, instead of changing the entire package's color.
- Delivering a package now outputs another, allowing you to continuously deliver throughout the round, should you choose to.
- Fixed cargo packages runtiming on the runtime map.
Geevies
requested review from
Arrow768,
alsoandanswer and
DreamySkrell
as code owners
github-actions
bot
added
🗺️ Mapping - Runtime
|
!review |
alsoandanswer
approved these changes
Oct 6, 2024
DreamySkrell
reviewed
Oct 8, 2024
| @@ -41,7 44,7 @@ | |||
| pay_amount = rand(12, 17) * 1000 | |||
| if(delivery_point) | |||
| setup_delivery_point(delivery_point) | |||
| color = pick("#FFFFFF", "#EEEEEE", "#DDDDDD", "#CCCCCC", "#BBBBBB", "#FFDDDD", "#DDDDFF", "#FFFFDD", "#886600") | |||
There was a problem hiding this comment.
I think this should stay
The colors here are like off-white shades of gray-ish
I think it makes sense that the courier packages aren't all perfectly shiny and white and clean
Cause they are used all over the spur and can come from anywhere
Comment on lines
79
to
84
| var/package_index = 1 | ||
| for(var/obj/item/cargo_package/package in contained_packages) | ||
| var/image/package_tag = image(icon, icon_state = "package_pack_[package_index]_tag") | ||
| package_tag.color = package.accent_color | ||
| mob_overlay.AddOverlays(package_tag) | ||
| package_index |
There was a problem hiding this comment.
Suggested change
| var/package_index = 1 | |
| for(var/obj/item/cargo_package/package in contained_packages) | |
| var/image/package_tag = image(icon, icon_state = "package_pack_[package_index]_tag") | |
| package_tag.color = package.accent_color | |
| mob_overlay.AddOverlays(package_tag) | |
| package_index | |
| for(var/package_index in 1 to lenght(contained_packages)) | |
| var/obj/item/cargo_package/package = contained_packages[package_index] | |
| var/image/package_tag = image(icon, icon_state = "package_pack_[package_index]_tag") | |
| package_tag.color = package.accent_color | |
| mob_overlay.AddOverlays(package_tag) |
Something like this is clearer
| var/obj/structure/cargo_receptacle/selected_delivery_point = get_cargo_package_delivery_point(src) | ||
| if(selected_delivery_point) | ||
| visible_message("\The [src] beeps, \"[SPAN_NOTICE("New package available for delivery.")]\"") | ||
| playsound(loc, /singleton/sound_category/print_sound, 50, TRUE) |
There was a problem hiding this comment.
Suggested change
| playsound(loc, /singleton/sound_category/print_sound, 50, TRUE) | |
| playsound(src, /singleton/sound_category/print_sound, 50, TRUE) |
There shouldn't be a need to use loc here, since it's a structure?
NonQueueingMatt
added
the
Changes Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.