Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The linker issue when using Carthage to build Siren library #125

Closed
yasuradodo opened this issue Feb 11, 2017 · 13 comments
Closed

The linker issue when using Carthage to build Siren library #125

yasuradodo opened this issue Feb 11, 2017 · 13 comments

Comments

@yasuradodo
Copy link

I'm using Xcode 8.2.1 and swift 3.0.2

func setupSiren() {
    let siren = Siren.sharedInstance
    siren.debugEnabled = true
    siren.alertType = .option
    siren.forceLanguageLocalization = .Japanese
    siren.checkVersion(checkType: .immediately)
}

When I built my app with Carthage, I got this error.
screen shot 2017-02-10 at 5 08 08 pm

And this error description is almost same with #112

Do you have any idea?
@yasuradodo
Copy link
Author

Temporally I just comment out a line like this:
// siren.debugEnabled = true

@ArtSabintsev
Copy link
Owner

What version of Siren are you using?

@yasuradodo
Copy link
Author

I'm using "1.1.3"

@ArtSabintsev
Copy link
Owner

Hmm, do you have a sample project you can send me? I don't use carthage myself, but I'm happy to help debug this issue.

@yasuradodo
Copy link
Author

I'm glad to hear you say that
please check my repo

@ArtSabintsev
Copy link
Owner

Working on it right now. Never seen this issue before.

@ArtSabintsev
Copy link
Owner

This is interesting. Apparently, Carthage has issues dealing with lazy variables.

Asking the community for help through other channels.

@calebd
Copy link

calebd commented Feb 17, 2017 •
edited
Loading

After some digging, this appears to be a Swift 3.0.x Whole Module Optimization bug. Switching precompiled framework targets to -Onone allows the build to complete successfully. It looks like this issue is fixed in the latest Xcode beta (8.3 beta 2).

@ArtSabintsev
Copy link
Owner

Thanks, @calebd!

@ArtSabintsev
Copy link
Owner

Closing this issue, but feel free to respond, @yasuralian.

@yasuradodo
Copy link
Author

Thank you @calebd @ArtSabintsev

@tatimagdalena
Copy link

I've seen this should be fixed on version 1.2.2, but I came across the same issue trying to use it from Carthage now.

It is giving me the same kind of error when trying to use differentiated Alerts for Major, Minor and Patch, and when trying to set appName...

@ArtSabintsev
Copy link
Owner

Can you make a new issue in Github, and link to this one? Thank you!

@tatimagdalena tatimagdalena mentioned this issue Apr 19, 2017
Closed
@msaps msaps mentioned this issue May 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ArtSabintsev @calebd @tatimagdalena @yasuradodo