Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Lints #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Lints #104

wants to merge 1 commit into from

Conversation

mberry
Copy link
Member

@mberry mberry commented Oct 12, 2023

  • Removes unnecessary borrows
  • Adds parentheses for clarity
  • Use subtraction assignment
  • Remove unnecessary indexing

@mberry
Fix: Lints
66c0f88 
Removes unecessary borrows
Adds parentheses for clarity
Use subraction assignment
Remove unecessary indexing
@mberry
Copy link
Member Author

mberry commented Oct 12, 2023 •
edited
Loading

So there seems to be an issue with cross compilation and cross-rs in general:

Status: Downloaded newer image for rustembedded/cross:mips64-unknown-linux-gnuabi64-0.1.15
   Compiling libc v0.2.149
   Compiling cfg-if v1.0.0
error[E0463]: can't find crate for `core`
  |
  = note: the `mips64-unknown-linux-gnuabi64` target may not be installed
  = help: consider downloading the target with `rustup target add mips64-unknown-linux-gnuabi64`

error[E0463]: can't find crate for `compiler_builtins`

Was going to leave this open for discussion for a week anyway so hopefully can sort out the CI issues by then.

@tarcieri
Copy link

@mberry MIPS was demoted to a Tier 3 target: rust-lang/rust#115218

I would suggest using powerpc-unknown-linux-gnu if you'd like to test against a 32-bit big endian Tier 2 target.

@mberry
Copy link
Member Author

mberry commented Oct 12, 2023

Thanks Tony, that's awesome, would really like to do the full spectrum for quick CI checks in cross.yaml but it's sometimes a moving target.

I'll hopefully try to adjust the scripts later today, Having a BE test is pretty much the important thing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mberry @tarcieri