Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra smartlauncher support #2095

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add extra smartlauncher support #2095

wants to merge 3 commits into from

Conversation

Donnnno
Copy link
Collaborator

@Donnnno Donnnno commented Apr 16, 2024

Smart launcher has some cool icon pack support.
Especially for Material You stuff.

https://docs.smartlauncher.net/work-with-smart-launcher/icon-packs

Duplicating the AndroidManifest.xml like a stupid way to do this tho...

@Donnnno Donnnno added enhancement New feature or request you arcticons you specific issue day & night Help wanted need some help with this one! labels Apr 16, 2024
@Kaiserdragon2
Copy link
Collaborator

https://developer.android.com/build/manage-manifests

This seems to be possible it should work similar to the configuration file for the dashboard where only the attributes that are different are declared

@Donnnno
Copy link
Collaborator Author

Donnnno commented Apr 16, 2024

Ah yeah, but the whole MainActivity block should be put into the file right?

        <activity
            android:name=".activities.MainActivity"
            android:launchMode="singleTop"
            android:theme="@style/Theme.App.Starting"
            android:configChanges="uiMode|orientation|keyboardHidden|screenSize"
            android:exported="true">

@Kaiserdragon2
Copy link
Collaborator

i have reduced it to this for the yuou variant and it seems to be merged correctly

<application>
    <activity
        android:name=".activities.MainActivity"
        android:exported="true">
        <!-- ADW Launcher -->
        <intent-filter tools:node="merge" >
            <action android:name="org.adw.launcher.THEMES" />
            <category android:name="android.intent.category.DEFAULT" />
            <category android:name="org.icontheme.CHANGES_WITH_MATERIAL_YOU_COLORS" />
            <category android:name="org.icontheme.FALLBACK_TO_THEMED_ICON" />
            <category android:name="org.icontheme.CHANGES_WITH_DARK_MODE" />
        </intent-filter>
    </activity>
</application>

@Donnnno
Copy link
Collaborator Author

Donnnno commented Apr 17, 2024

Oh nice! Can you merge it into this commit or create a new one? :)

@Kaiserdragon2
Copy link
Collaborator

Oh nice! Can you merge it into this commit or create a new one? :)

Pushed to it

@Donnnno
Copy link
Collaborator Author

Donnnno commented Apr 17, 2024

thank you!

@DeltriDev
Copy link
Contributor

Nice, I use smart launcher, and that's pretty neat

@Donnnno
Copy link
Collaborator Author

Donnnno commented Jun 1, 2024

So in my initial testings, the extra lines caused the features to not work.
I have to take a look again in the future what causes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
day & night enhancement New feature or request Help wanted need some help with this one! you arcticons you specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants