Added unit index to radar statement #6017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anuken
reviewed
Sep 18, 2021
| @@ -747,7 750,8 @@ public void run(LExecutor exec){ | |||
| } | |||
| } | |||
|
|
|||
| void find(Ranged b, float range, int sortDir, Team team){ | |||
| void find(Ranged b, float range, int sortDir, Team team, int idx){ | |||
| ObjectMap<Float, Unit> units = new ObjectMap<>(); | |||
There was a problem hiding this comment.
This violates the contribution guidelines in two ways:
- Boxed
Floatused. - Large allocation in main loop.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The radar statement now returns a unit based on the index after sorting. For example, when index is 0(and sort is distance and sortOrder is 1), the closest unit is returned. When the index is 1, the second closest unit is returned and so on. If the index is higher than the number of units nearby, the result is null.
Demo program:
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: