Added Unit test #5303
Closed
Added Unit test #5303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chefk initial items test case updated
Anuken
requested changes
May 30, 2021
| @@ -21,7 21,7 @@ | |||
| import mindustry.type.*; | |||
| import mindustry.world.*; | |||
| import org.junit.jupiter.api.*; | |||
|
|
|||
| import mindustry.editor.*; | |||
| @@ -136,6 136,40 @@ void spawnWaves(){ | |||
| assertFalse(Groups.unit.isEmpty(), "No enemies spawned."); | |||
| } | |||
|
|
|||
| @Test | |||
| void checkInitialItems() { | |||
There was a problem hiding this comment.
I don't really see the purpose of this test. It may not always be the case that every map has 200 copper as a starting item, and some maps may not have any starting items at all. If I ever increase the starting copper amount to 300 copper, this test will break.
| } | ||
|
|
||
| @Test | ||
| void TeamsStatusTest() { |
There was a problem hiding this comment.
spurious
Suggested change
| void TeamsStatusTest() { | |
| void TeamsStatusTest(){ |
| @@ -235,6 269,8 @@ void load(){ | |||
| assertTrue(state.teams.playerCores().size > 0); | |||
| } | |||
|
|
|||
|
|
|||
| @@ -268,6 304,8 @@ void liquidOutput(){ | |||
| assertTrue(world.tile(2, 1).build.liquids.current() == Liquids.water); | |||
| } | |||
|
|
|||
|
|
|||
|
we fixed the issues you mentioned and send a new commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three test cases testing the logic of the game.