Skip to content
This repository has been archived by the owner on Aug 17, 2020. It is now read-only.

Add support for file input #10

Open
AucT opened this issue Feb 3, 2018 · 5 comments
Open

Add support for file input #10

AucT opened this issue Feb 3, 2018 · 5 comments
Labels
awaiting specification feature request in discussion

Comments

@AucT
Copy link

AucT commented Feb 3, 2018

Add support for file input
@Andy-set-studio
Copy link
Owner

Good shout, @nchan0154!

@nchan0154
Copy link
Contributor

What would an ideal solution look like to you? Typically I would style it the same as how other buttons are styled.

@Andy-set-studio
Copy link
Owner

I think that's a good call @nchan0154. I think that we'd want to replicate the 'no file chosen' label/status too.

The "File Browser" on WTF forms is decent, but the state doesn't change when a file is added.

@tcaruth
Copy link
Contributor

tcaruth commented Feb 5, 2018

WTF, forms? is only css. To my knowledge, the filename can't be put in a custom element without javascript.

@Andy-set-studio
Copy link
Owner

Yeh I thought that might be the case and it’s something I’m not averse to. We’ve already got modular setup with the JavaScript, so we could add some progressive enhancements where needed.

The label’s visibility could be based on the <html> element having a js class, or not having a no-js class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
awaiting specification feature request in discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AucT @tcaruth @Andy-set-studio @nchan0154