Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dragging tickmark problems #46

Closed
briantoby opened this issue Jul 20, 2024 · 3 comments
Closed

dragging tickmark problems #46

briantoby opened this issue Jul 20, 2024 · 3 comments
Assignees
@briantoby
Labels
bug Something isn't working Someday... Problem noted, but will not be addressed right now.

Comments

@briantoby
Copy link
Collaborator

Dragging tickmarks can have two problems that do not happen most of the time and might be MacOS only.

  1. dragging the tickmarks causes Python to crash (ouch!)

  2. dragging the tickmarks seems to work, but when the mouse is released the new position is not saved.

Restarting GSAS-II seems to make the problem go away for a while
@briantoby briantoby added bug Something isn't working Someday... Problem noted, but will not be addressed right now. labels Jul 20, 2024
@briantoby briantoby self-assigned this Jul 20, 2024
briantoby added a commit that referenced this issue Aug 26, 2024
@briantoby
consider tickmark crash (#46): add CallAfter, preven diff curve drag …
d0c8359 
…in Peak Lists
@briantoby
Copy link
Collaborator Author

Perhaps a CallAfter will fix problem 1. above.

Changed the one direct call to PlotPatterns in OnRelease to a CallAfter in d0c8359

While at it, prevent accidental dragging of difference curve in Peak Lists.

@briantoby
Copy link
Collaborator Author

briantoby commented Oct 10, 2024 •
edited
Loading

Reproduced drag failure 2 (saw 1 too, crash but not reproduced yet)

with file /Users/toby/Scratch/reftest.gpx
Tick marks drag with initial plot, but after a refinement, they appear to drag, but after release they return to their original position.

briantoby added a commit that referenced this issue Oct 10, 2024
@briantoby
fix tickmark drag bug (#46) -- I hope; bug caused by reference to old…
1eea656 
… tree item after a refinement
@briantoby
Copy link
Collaborator Author

fixed I think.

When a refinement is done and the .gpx is reloaded, all tree items change. A saved reference to an old tree item sometimes caused the new tickmark location not to be saved or even to have Python crash.

This has been a long time in coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briantoby briantoby

Labels
bug Something isn't working Someday... Problem noted, but will not be addressed right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briantoby