Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Clone bound on map_tabs and filter_map_tabs #241

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Remove Clone bound on map_tabs and filter_map_tabs #241

merged 4 commits into from
Jul 3, 2024

Conversation

Ved-s
Copy link

@Ved-s Ved-s commented May 30, 2024

No point of having a FnMut if it can't mutably reference stuff outside

Adanos020
Adanos020 reviewed Jun 2, 2024
View reviewed changes
Copy link
Owner

@Adanos020 Adanos020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good change. I noticed you haven't applied it to {DockState,Surface,Tree}::{filter_tabs,retain_tabs} and {Surface,Tree}::map_tabs, is there a particular reason for this?

Also, since this is an API change, I'll move it to release-0.13.

@Adanos020 Adanos020 changed the base branch from main to release-0.13 June 2, 2024 10:00
@Ved-s
Copy link
Author

Ved-s commented Jun 2, 2024

I noticed you haven't applied it to {DockState,Surface,Tree}::{filter_tabs,retain_tabs} and {Surface,Tree}::map_tabs, is there a particular reason for this?

I guess i just removed it from the stuff i used and didn't check for other instances of it.
Fixed

@Adanos020 Adanos020 changed the base branch from release-0.13 to release-0.14 July 3, 2024 18:33
Adanos020
Adanos020 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Owner

@Adanos020 Adanos020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the massive delay, my irl stuff has been insane in the last 2 months.

The changes look good, merging them soon after I've updated the changelog. Thank you!

@Adanos020 Adanos020 merged commit f3a709f into Adanos020:release-0.14 Jul 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adanos020 Adanos020 Adanos020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ved-s @Adanos020