Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Option to Skip initial upscale of input for Live mode #1470

Closed
Apacchi88 opened this issue Dec 8, 2024 · 2 comments
Closed

[Feature Request] Option to Skip initial upscale of input for Live mode #1470

Apacchi88 opened this issue Dec 8, 2024 · 2 comments

Comments

@Apacchi88
Copy link

The live workflow that it spits out when I bring it into comfyui, I see that the start latent is much higher than what the document resolution is and then downscales the image to the document resolution.

Is it possible to have an option to respect the desired start/current resolution of document, or to skip this upscale/downscale step?

image
image
image
@Acly
Copy link
Owner

Acly commented Dec 10, 2024

The idea of that is to avoid generating garbage when resolution is below what the model can handle. At some point quality deteriorates and images become unusable.

It looks like the minimum is a bit too high for SDXL though, while it prefers resolutions in 1MP range, it works decently down to 512x512 or so (mild quality loss). So for now I'd rather just lower the threshold. You will no longer get upscales unless you drop to really low resolution.

Acly added a commit that referenced this issue Dec 10, 2024
@Acly
Lower minimum resolution for SDXL #1470
1102597
@Apacchi88
Copy link
Author

The idea of that is to avoid generating garbage when resolution is below what the model can handle. At some point quality deteriorates and images become unusable.

It looks like the minimum is a bit too high for SDXL though, while it prefers resolutions in 1MP range, it works decently down to 512x512 or so (mild quality loss). So for now I'd rather just lower the threshold. You will no longer get upscales unless you drop to really low resolution.

Awesome thanks for the reply, I found out about the threshholds afterwards, and that really helped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Acly @Apacchi88