FIX: Fix for new xarray check for dtype. #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kenkehoe can we always assume that time bounds are always going to be floats? |
|
Yeah if it does change, I can try to find a way to automate it. |
|
I believe time_bouds by ARM standards will always be a float (type float or double). It should be the number of seconds to add and subtract to define the bound. It should match the same type as the written time coordinate variable. Since Xarray converts time upon reading to datetime64 but not time_bounds it should stay a float. |
mgrover1
approved these changes
Feb 26, 2024
|
@AdamTheisen Good to merge? |
AdamTheisen
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to understand the encoding was a learning experience to say the least. The input encoding is 'float64' so I set it to that. 'datetime64[ns]' does not work.