Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Reverting back the secondary y-axis change and removing the seco… #769

Merged
merged 2 commits into from
Dec 11, 2023
Merged

ENH: Reverting back the secondary y-axis change and removing the seco… #769

merged 2 commits into from
Dec 11, 2023

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented Dec 11, 2023 •
edited
Loading

…ndary y-axis functionality.

zssherman
zssherman requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@zssherman zssherman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, seems to be mostly PEP8 errors @AdamTheisen .

mgrover1
mgrover1 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good @AdamTheisen

@mgrover1 mgrover1 merged commit e9cc16e into ARM-DOE:main Dec 11, 2023
16 checks passed
@AdamTheisen AdamTheisen deleted the revert_y branch December 11, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zssherman zssherman zssherman approved these changes

@mgrover1 mgrover1 mgrover1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secondary Y-Display breaks convention with Matplotlib
3 participants
@AdamTheisen @zssherman @mgrover1