Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use arm-test-data repo for unit testing #762

Merged
merged 9 commits into from
Dec 1, 2023

Conversation

zssherman
Copy link
Collaborator

@zssherman zssherman commented Nov 30, 2023

This uses pooch fetch and the new arm-test-repo for unit testing. Will update examples and remove test data in a separate PR. After discussion, running test file will download all, as unittests should run completely when adding tests to avoid issues.

  • Tests added
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! Thanks for putting this together @zssherman

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait - one more change here... can you delete the test data from the repo?

@zssherman
Copy link
Collaborator Author

@mgrover1 I'm going to do that in the next PR once I switch over the examples

@mgrover1
Copy link
Collaborator

mgrover1 commented Dec 1, 2023

Ahh okay! All good then!

@zssherman zssherman merged commit 0feedb9 into ARM-DOE:main Dec 1, 2023
16 checks passed
@zssherman zssherman deleted the arm_test_data branch January 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants