Improvements for the secondary y axis functionality #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge in how we do things and might need to be considered for a v2.0
|
@AdamTheisen Looks fairly reasonable to me. Tests are failing due to that geoplot issue. |
mgrover1
approved these changes
Nov 29, 2023
zssherman
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the functionality of what's returned as part of the display.axes object. For the TimeSeriesDisplay and DistributionDisplay it will now return a 2D array for each plot (left and right axis object) instead of a 1D array of just the left axis object for each plot. This will break conventions so might be something we consider for V2.0.0