Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make gaussian randomizer use cuda #124

Merged
merged 2 commits into from
Dec 22, 2023
Merged

make gaussian randomizer use cuda #124

merged 2 commits into from
Dec 22, 2023

Conversation

cremebrule
Copy link
Member

No description provided.

amandlek
amandlek requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@amandlek amandlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably detect what device the input is on, and set the device for the noise appropriately, instead of always assuming gpu

amandlek
amandlek approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@amandlek amandlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amandlek amandlek merged commit bdc89f7 into master Dec 22, 2023
@amandlek amandlek deleted the fix/gaussian-randomizer branch December 22, 2023 18:06
Eubooks3003 pushed a commit to Eubooks3003/robomimic that referenced this pull request Oct 7, 2024
@cremebrule
make gaussian randomizer use cuda (ARISE-Initiative#124)
375e3df 
* make gaussian randomizer use cuda

* make randomized torch tensor use same device as inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandlek amandlek amandlek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cremebrule @amandlek