Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] - Better job blacklisting with regex #743

Merged
merged 5 commits into from
Nov 4, 2024
Merged

[FEATURE] - Better job blacklisting with regex #743

merged 5 commits into from
Nov 4, 2024

Conversation

GuilhermeRameh
Copy link
Contributor

Solves #667

What i added:

  • import of re library for regex
  • added regex pattern generation on "set_parameters" function to run it only at the start
  • added function "generate_regex_patterns" for the generation itself, based on the blacklist parameters already defined before
  • modified "is_blacklisted" function to use re library and regex patterns created

Local tests were successfull:
image

If there is anything else i need to add, im happy to work on it!

surapuramakhil
surapuramakhil suggested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@surapuramakhil surapuramakhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @GuilhermeRameh

src/ai_hawk/job_manager.py Outdated Show resolved Hide resolved
src/ai_hawk/job_manager.py Outdated Show resolved Hide resolved
@surapuramakhil surapuramakhil self-requested a review November 4, 2024 14:49
@GuilhermeRameh
Copy link
Contributor Author

Changes added!

@surapuramakhil surapuramakhil merged commit f5e6ffc into AIHawk-FOSS:release/v11.15.2024 Nov 4, 2024
1 check passed
@GuilhermeRameh GuilhermeRameh mentioned this pull request Nov 6, 2024
Merged
@surapuramakhil surapuramakhil linked an issue Nov 21, 2024 that may be closed by this pull request
[BUG]: Filtering by role titles and blacklisting doesn't work #537
Closed
DanielT504 pushed a commit to DanielT504/Auto_Jobs_Applier_AI_Agent that referenced this pull request Dec 21, 2024
@surapuramakhil
Merge pull request AIHawk-FOSS#743 from GuilhermeRameh/Blacklist-Regex
a7ef6cf 
[FEATURE] - Better job blacklisting with regex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surapuramakhil surapuramakhil surapuramakhil approved these changes

Assignees

@GuilhermeRameh GuilhermeRameh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Filtering by role titles and blacklisting doesn't work
2 participants
@GuilhermeRameh @surapuramakhil