Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Fixing coala issues #127

Merged
merged 1 commit into from
May 16, 2019
Merged

Fixing coala issues #127

merged 1 commit into from
May 16, 2019

Conversation

zak-hassan
Copy link
Contributor

Description

Fixing failing bot tests.

@ghost
Copy link

ghost commented May 14, 2019

Build failed.

@zak-hassan
Copy link
Contributor Author

Majority of the fixes coala recommended where all about adding comments which is good. I'll be adding more comments or can we skip the comments and just have it validate just pylint, pep8, flake8 the standard stuff.

@goern
Copy link
Member

goern commented May 15, 2019

[...] or can we skip the comments and just have it validate just pylint, pep8, flake8 the standard stuff.

You can, by removing the thoth-coala job from the pipeline. But I really dont see the point of replacing coala with pep8/flake8 as both will raise the same errors.

@goern goern requested a review from durandom May 15, 2019 06:42
@ghost
Copy link

ghost commented May 15, 2019

Build failed.

@ghost
Copy link

ghost commented May 15, 2019

Build succeeded.

@goern
Copy link
Member

goern commented May 15, 2019

@zmhassan this commit message "Removing pydocbear as its not necessary" is misleading, you are removing it because it is slowing down the process.

@zak-hassan
Copy link
Contributor Author

@goern Please merge this if this looks good to you ? @durandom thoth-bot test passes for coala

@zak-hassan zak-hassan requested a review from goern May 15, 2019 14:33
@goern
Copy link
Member

goern commented May 15, 2019

no, I dont merge on this repo, that is something who can do a review needs to do

@zak-hassan
Copy link
Contributor Author

@durandom Can you help us out here with a review and merge if this looks good?

Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmhassan please keep the PyDocStyleBear and fix the missing doc blocks.
PyCharm can help you.

.coafile Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented May 15, 2019

Build succeeded.

@zak-hassan
Copy link
Contributor Author

@goern @durandom So now its all passing with the documentation style rules. Can we finally merge this ?

@ghost
Copy link

ghost commented May 15, 2019

Build succeeded.

@zak-hassan
Copy link
Contributor Author

zak-hassan commented May 15, 2019

How do I remove stickler from our git pr's?

@durandom
Copy link
Member

Awesom. Now we have a celebration cola, ehrm, coala-🐻

@zmhassan right, I've removed stickler. Shall we also remove travis?

@durandom durandom merged commit d8caef7 into AICoE:master May 16, 2019
@durandom
Copy link
Member

just disabled travis... thoth FTW

zak-hassan pushed a commit to zak-hassan/log-anomaly-detector that referenced this pull request May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants