-
Notifications
You must be signed in to change notification settings - Fork 130
Conversation
Build failed.
|
Majority of the fixes coala recommended where all about adding comments which is good. I'll be adding more comments or can we skip the comments and just have it validate just pylint, pep8, flake8 the standard stuff. |
You can, by removing the thoth-coala job from the pipeline. But I really dont see the point of replacing coala with pep8/flake8 as both will raise the same errors. |
Build failed.
|
Build succeeded.
|
@zmhassan this commit message "Removing pydocbear as its not necessary" is misleading, you are removing it because it is slowing down the process. |
no, I dont merge on this repo, that is something who can do a review needs to do |
@durandom Can you help us out here with a review and merge if this looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmhassan please keep the PyDocStyleBear and fix the missing doc blocks.
PyCharm can help you.
Build succeeded.
|
Build succeeded.
|
How do I remove stickler from our git pr's? |
Awesom. Now we have a celebration cola, ehrm, coala-🐻 @zmhassan right, I've removed stickler. Shall we also remove travis? |
just disabled travis... thoth FTW |
Description
Fixing failing bot tests.