-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To support AFL instrumentation, add default settings of map_size in forkserver. #2173
Conversation
wouldn't it be easier to just check if map_size is 0 and then set the MAP_SIZE value if so? |
ping @ahuo1 |
Oh, I'm very sorry. Line 2463 in db23931
|
Oh, I overlooked cmplog. I think it would be more convenient to add a check within the afl_fsrv_get_mapsize function. AFLplusplus/src/afl-forkserver.c Line 1692 in db23931
|
Just push the change and then I can review it :) |
Alright! |
one thing so. what happens if the map size would be exactly DEFAULT_SHMEM_SIZE by chance? |
Uh, yeah. To deal with it, I think the first commit is more reasonable... |
thank you |
Hello, when aflpp uses a binary instrumented by AFL, the binary's returned status variable is 0.
Therefore, the bitmap size for aflpp is the default 8 /* 1024 /* 1024, which severely affects the running speed.
For compatibility, I have added a default bitmap size setting in forkserver.( ◠‿◠ )
ps: I noticed that it can be resolved by setting AFL_SKIP_BIN_CHECK. However, after setting AFL_SKIP_BIN_CHECK, aflpp will no longer check persistent mode. Therefore, I think this setting is more reasonable.