Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all warnings #1

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Remove all warnings #1

merged 1 commit into from
Jan 17, 2022

Conversation

crobibero
Copy link
Contributor

@crobibero crobibero commented Jan 17, 2022

Signed-off-by: Cody Robibero [email protected]

Untested, but I didn't change any logic.
Review with whitespace disabled.

This will also allow a Jellyfin server with a BaseUrl set to provide the proper redirect url

Signed-off-by: Cody Robibero <[email protected]>
@9p4
Copy link
Owner

9p4 commented Jan 17, 2022

Looks good to me. I'll run some tests then merge. Thanks!

@9p4
Copy link
Owner

9p4 commented Jan 17, 2022

Seems like the subdirectory functionality doesn't work because of the hardcoded path in the JavaScript response. I'll work on patching that.

@9p4 9p4 merged commit 3300022 into 9p4:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants