Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: slickGridVersion property should also be updated in slick.grid #717

Merged
merged 1 commit into from
Dec 28, 2022
Merged

chore: slickGridVersion property should also be updated in slick.grid #717

merged 1 commit into from
Dec 28, 2022

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Dec 27, 2022 •
edited
Loading

  • release script should also update slickGridVersion, it seems like this was missed in original script.

image

  • I have done a dry-run and it seems to be all good

first replacement

image

second replacement

image

@ghiscoding ghiscoding requested a review from 6pac December 27, 2022 05:31
@ghiscoding ghiscoding changed the title chore: slickGridVersion property should also be update in slick.grid chore: slickGridVersion property should also be updated in slick.grid Dec 27, 2022
@6pac 6pac merged commit 9e3d948 into master Dec 28, 2022
@ghiscoding ghiscoding deleted the chore/slickgrid-version-replacement branch December 29, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6pac 6pac Awaiting requested review from 6pac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @6pac