Fix issue with vertical scrollbar not going all the way down #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems to not change much on my side, so I guess it's ok |
|
@6pac |
|
@6pac |
|
OK, shall I do a release now? |
|
Yes that would be great, thanks mate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our company use the slickgrid and we had an issue with the vertical scrollbar not going all the way down in some scenarios. There is a gap at the bottom and there is no way to drag the scrollbar all the way down. The horizontal scrollbar is visible and the fault is that the code does not acknowledge this. There is a line in the code that determines if the horizontal scrollbar is visible but this misses with one pixel. The changed formula uses greater than or equal instead of only greater than. I saw that this solution was proposed in a PR long time ago to mleibman:
https://github.com/mleibman/SlickGrid/pull/1030/files