Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: 6pac/SlickGrid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.4.33
Choose a base ref
...
head repository: 6pac/SlickGrid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.4.34
Choose a head ref
  • 9 commits
  • 13 files changed
  • 7 contributors

Commits on Feb 3, 2021

  1. Feature total count (#573)

    * added `composer.json` to allow fetching of SlickGrid as `composer` package
    
    * feat(plugins): add header/grid menu item "hidden" property
    - in some cases we might want to use "disabled" but in other cases we might want to use "hidden"
    
    * refactor(plugins): add "hidden" property to HeaderButton plugin as well
    
    * refactor(plugins): add "hidden" property to all plugins with menu items
    
    * refacor(plugins): add "hidden" property everywhere potentially called
    
    * Feature:TotalCount in Pager - it's now possible to show the number of rows (and begin and end position) in pager
    
    Co-authored-by: arash dalir <[email protected]>
    Co-authored-by: ghiscoding <[email protected]>
    3 people authored Feb 3, 2021
    Configuration menu
    Copy the full SHA
    220a9f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. only use Colum Name for dropped Group Name (#581)

    Now, if the dropped column header contains an element with class 'slick-column-name', only the text content of that element is used to populate the dropped grouping represenation. This prevents additional column header content from being displayed (like the order number in case of sorting by multiple columns).
    der-david authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3991679 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. feat: expose reRenderColumns as public method (#583)

    - this will help in calculation our own column widths and calling `reRenderColumns` to resize columns accordingly
    ghiscoding authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    3f6e7d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. fix: add preventDefault to optionally leave plugin menu open (#589)

    - fixes #582
    - the original issue only mentioned the HeaderMenu plugin but I went ahead and applied the same logic (and tested them all) on the following plugins
       - HeaderMenu
       - GridMenu
       - ContextMenu
       - CellMenu
    ghiscoding authored Mar 21, 2021
    Configuration menu
    Copy the full SHA
    c7dfe45 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Fixes for issues with frozen columns, column reordering, and preheade…

    …r visibility (#591)
    
    * Two changes made for better support for frozen columns with column reordering enabled.
    
    slick.draggablegrouping.js 
    Only one header's ids were being accounted for after a drag and drop reorder when columns were frozen. the result is that the left (frozen) columns were fine, but the right (unfrozen) columns were 1) not sorted, and b) turned off.
    
    slick.grid.js
    Similar to the draggablegrouping issue, the grid was not honoring the preheader state for the unfrozen columns because only hte preheaderPanelScroller was  being updated setPreHeaderPanelVisibility. For me this showed itself because I had teh preheader row toggled off and froze some columns and the headers disappeared for my unfrozen columns due to the preheader row being visible but empty and the headers being under the first row of data.
    
    * Updated draggableGrouping changes with comments and added fixes that properly use ids.header.sortable("toArray") as the array to loop on.
    
    * changed ctr to headerI for better clarity.
    
    * further correction to second for loop, it should have been pushing from the ids variable rather than header variable.
    
    I also renamed headerI2 to idI and l2 to idL for the index and length variables in the for loop.
    
    * corrected for hiding rather than slideDown for non visible non animated right column.
    arthur-clifford authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    53ffd28 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. To Fix the issue specific to drag selection in non-frozen part of gri…

    …d if there are multiple grids. (#593)
    
    * To Fix the issue specific to drag selection in non-frozen part of grid if there are multiple grids.
    
    Issue Description: if we have multiple grids in same page/in the DOM, the above code looks for  '.grid-canvas-left' width which indeed gets the result of the grid where the event triggered and the other grids present in the DOM. If the action is done on second grid(which has frozen column) instead of first one above code is getting the width of first grid instead of second one. So made changes to get the width only for the event triggered grid.
    
    * As per request changed the syntax to ES5 to support legacy browser
    Hunt05 authored Apr 1, 2021
    Configuration menu
    Copy the full SHA
    3501147 View commit details
    Browse the repository at this point in the history
  2. feat: add target to onBeforeEditCell (#863)

    - the available `target` options will be: "grid" or "composite"
     - since we can also use the `onBeforeEditCell` event within the Composite Editor, I needed a way to make a distinction between a call made with `onBeforeEditCell` from the grid or from the composite component. This `target` will let me know where it was executed from.
    ghiscoding authored Apr 1, 2021
    Configuration menu
    Copy the full SHA
    e06f1a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. feat: add better error message when throwing (#599)

    - since SlickGrid can be used in other libs and components, it could be useful to be more explicite from where the error originated, add SlickGrid prefixes to all error messages
    ghiscoding authored Apr 9, 2021
    Configuration menu
    Copy the full SHA
    4bac2f8 View commit details
    Browse the repository at this point in the history
  2. release v2.4.34

    6pac committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    3e306fa View commit details
    Browse the repository at this point in the history
Loading