Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint error when building frontend #7198

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix lint error when building frontend #7198

merged 1 commit into from
Nov 27, 2024

Conversation

JohnNiang
Copy link
Contributor

@JohnNiang JohnNiang commented Nov 27, 2024 •
edited
Loading

What this PR does / why we need it?

The following error will be complained during building frontend project at dev branch(b8d8867):

x Build failed in 30.00s
error during build:
[vite-plugin-eslint] [plugin vite-plugin-eslint] src/views/setting/panel/api-interface/index.vue: [plugin vite-plugin-eslint] src/views/setting/panel/api-interface/index.vue: 
/home/johnniang/workspaces/1Panel-dev/1Panel/frontend/src/views/setting/panel/api-interface/index.vue
  183:10  error  Insert `⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Summary of your change

This PR inserts a ⏎ at the end of that file to make the build successful.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.
None

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengkunwang223 zhengkunwang223 merged commit f7dcaca into 1Panel-dev:dev Nov 27, 2024
1 of 3 checks passed
@JohnNiang JohnNiang deleted the chore/lint-error branch November 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees
No one assigned
Labels
release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnNiang @zhengkunwang223