Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio track constraints when krisp is enabled #3374

Merged
merged 6 commits into from
Nov 22, 2024
Merged

fix: audio track constraints when krisp is enabled #3374

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
11b3734
fix: audio track constraints when krisp is enabled
KaustubhKumar05 Nov 18, 2024
a52d7a7
fix: update krisp version
KaustubhKumar05 Nov 18, 2024
5a11e75
fix: bump hms-nc version
KaustubhKumar05 Nov 20, 2024
bef3fb9
fix: remove redundant method
KaustubhKumar05 Nov 22, 2024
3bfded4
fix: bump krisp
KaustubhKumar05 Nov 22, 2024
bbc61d7
fix: refactor, bump version
KaustubhKumar05 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove redundant method
  • Loading branch information
@KaustubhKumar05
KaustubhKumar05 committed Nov 22, 2024
commit bef3fb9c0d651b166991d3269a946da62b5ff0e8
18 changes: 0 additions & 18 deletions packages/hms-video-store/src/media/settings/HMSAudioTrackSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,24 59,6 @@ export class HMSAudioTrackSettingsBuilder {
return this;
}

updateConstraints(overrides: Partial<Array<MediaTrackConstraintSet>>) {
const constraintsMap = new Map<string, MediaTrackConstraintSet>();
this._advanced.forEach(constraint => {
const key = Object.keys(constraint)[0];
constraintsMap.set(key, constraint);
});

Object.entries(overrides).forEach(([key, value]) => {
if (value !== undefined) {
// @ts-ignore
constraintsMap.set(key, { [key]: { exact: value['exact'] } });
}
});

this._advanced = Array.from(constraintsMap.values());
return this;
}

advanced(advanced: Array<MediaTrackConstraintSet>) {
this._advanced = advanced;
return this;
Expand Down
30 changes: 28 additions & 2 deletions packages/hms-video-store/src/plugins/audio/HMSAudioPluginsManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 91,20 @@ export class HMSAudioPluginsManager {
.codec(settings.codec)
.maxBitrate(settings.maxBitrate)
.deviceId(settings.deviceId!)
.updateConstraints([{ autoGainControl: { exact: false } }, { noiseSuppression: { exact: false } }])
.advanced([
// @ts-ignore
{ googEchoCancellation: { exact: true } },
// @ts-ignore
{ googExperimentalEchoCancellation: { exact: true } },
// @ts-ignore
{ autoGainControl: { exact: false } },
// @ts-ignore
{ noiseSuppression: { exact: false } },
// @ts-ignore
{ googHighpassFilter: { exact: true } },
// @ts-ignore
{ googAudioMirroring: { exact: true } },
])
.audioMode(settings.audioMode)
.build();
await this.hmsTrack.setSettings(newAudioTrackSettings);
Expand Down Expand Up @@ -180,7 193,20 @@ export class HMSAudioPluginsManager {
.codec(settings.codec)
.maxBitrate(settings.maxBitrate)
.deviceId(settings.deviceId!)
.updateConstraints([{ autoGainControl: { exact: true } }, { noiseSuppression: { exact: true } }])
.advanced([
// @ts-ignore
{ googEchoCancellation: { exact: true } },
// @ts-ignore
{ googExperimentalEchoCancellation: { exact: true } },
// @ts-ignore
{ autoGainControl: { exact: true } },
// @ts-ignore
{ noiseSuppression: { exact: true } },
// @ts-ignore
{ googHighpassFilter: { exact: true } },
// @ts-ignore
{ googAudioMirroring: { exact: true } },
])
.audioMode(settings.audioMode)
.build();
await this.hmsTrack.setSettings(newAudioTrackSettings);
Expand Down