Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove autohide controls for mweb #3355

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: remove autohide controls for mweb #3355

merged 1 commit into from
Nov 18, 2024

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Nov 4, 2024 •
edited
Loading

  • For the next release
  • Remove tap to toggle header and footer behaviour

Test scenarios

  • Mweb HLS stream - viewer roles (Should remain hidden, same behaviour as prod)
  • Mweb conference and broadcaster roles (Should always be visible, no autohide)

@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 6:37am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 6:37am

@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review November 4, 2024 11:29
ygit
ygit approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaustubhKumar05 KaustubhKumar05 merged commit 9e526fb into dev Nov 18, 2024
4 checks passed
@KaustubhKumar05 KaustubhKumar05 deleted the fix/WEB-3043-remove-autohide-controls branch November 18, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdz-666 hdz-666 hdz-666 approved these changes

@ygit ygit ygit approved these changes

@raviteja83 raviteja83 Awaiting requested review from raviteja83

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaustubhKumar05 @ygit @hdz-666