fix: adjust tile dimension calculation to handle 480p recording #3351

KaustubhKumar05 · 2024-10-29T10:22:13Z

Before:

Fix: The tiles have a gap of 8px. The tile dim calculation does not account for this. The gaps should be subtracted from each tile's height and width depending on the number of rows and columns

vercel · 2024-10-29T10:22:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 6:11am
storybook-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 6:11am

fix: adjust tile calc to handle 480p recording

1f35f2a

vercel bot deployed to Preview – dashboard-app October 29, 2024 10:25 View deployment

vercel bot deployed to Preview – storybook-app October 29, 2024 10:26 View deployment

fix: generic fix for tile dims

3adccaa

vercel bot deployed to Preview – dashboard-app October 29, 2024 10:58 View deployment

vercel bot deployed to Preview – storybook-app October 29, 2024 10:59 View deployment

fix: reduce dims proportionally

e6e27c1

vercel bot deployed to Preview – dashboard-app October 29, 2024 11:07 View deployment

vercel bot deployed to Preview – storybook-app October 29, 2024 11:08 View deployment

fix: comment

cba7664

vercel bot deployed to Preview – dashboard-app October 29, 2024 11:28 View deployment

vercel bot deployed to Preview – storybook-app October 29, 2024 11:29 View deployment

fix: use gap var

04c1ab6

vercel bot deployed to Preview – dashboard-app October 30, 2024 06:06 View deployment

vercel bot deployed to Preview – storybook-app October 30, 2024 06:07 View deployment

fix: gap check

0205273

vercel bot deployed to Preview – dashboard-app October 30, 2024 06:10 View deployment

vercel bot deployed to Preview – storybook-app October 30, 2024 06:11 View deployment

KaustubhKumar05 marked this pull request as ready for review October 30, 2024 06:26

KaustubhKumar05 requested review from raviteja83 and amar-1995 as code owners October 30, 2024 06:26

KaustubhKumar05 requested review from ygit and hdz-666 October 30, 2024 06:29

raviteja83 approved these changes Oct 30, 2024

View reviewed changes

hdz-666 approved these changes Oct 30, 2024

View reviewed changes

KaustubhKumar05 merged commit d75edb2 into dev Oct 30, 2024
3 of 4 checks passed

KaustubhKumar05 deleted the fix/WEB-3062-recording-layout-480p branch October 30, 2024 09:10