Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge reverted changes #3312

Merged
merged 15 commits into from
Oct 15, 2024
Merged

feat: merge reverted changes #3312

merged 15 commits into from
Oct 15, 2024

Conversation

raviteja83
Copy link
Collaborator

Details(context, link the issue, how was the bug fixed, what does the new feature do)

Implementation note, gotchas, related work and Future TODOs (optional)

ygit and others added 14 commits October 3, 2024 16:23
@ygit
fix: make interruption reason generic (#3290)
bc21ddf
@ygit
fix: wrong color applied for vb selection in mweb (#3283)
201a92f
@hdz-666
feat: add debug info in stats for nerds
6239e8a
@raviteja83 @KaustubhKumar05 @hdz-666
feat: upgrade stitches (#3308)
496f584 
Co-authored-by: Kaustubh Kumar <[email protected]>
Co-authored-by: hdz-666 <93115614 [email protected]>
@ygit
refactor: Notifications in prebuilt (#3307)
2b8b069
@amar-1995
fix: audio not audible when audio decode error occurs (#3289)
51976c4
@raviteja83 @ygit
fix: add an event when tracks are published with no data (#3298)
bc76e24 
Co-authored-by: Yogesh Singh <[email protected]>
@hdz-666
fix: notification api support check (#3304)
2b88485
@KaustubhKumar05
fix: clean up mediastream plugins (#3287)
75e9ead
@ygit
fix: crash on publishing role to non-publishing role and back (#3299)
70cb71f
@eswarclynn
fix: device in use error modal
c8799db
@raviteja83
feat: lazy load less frequently used components (#3010)
ddcd47e
@ygit
fix: make role change notification an independent component
780129c
@raviteja83
fix: use copy loader for images
258ec48
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 8:20am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 8:20am

@raviteja83 raviteja83 marked this pull request as draft October 10, 2024 12:00
@raviteja83 raviteja83 marked this pull request as ready for review October 15, 2024 08:09
@raviteja83 raviteja83 changed the title fix: use copy loader for images feat: merge reverted changes Oct 15, 2024
ygit
ygit approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raviteja83 raviteja83 changed the title feat: merge reverted changes [Don't merge] feat: merge reverted changes Oct 15, 2024
@raviteja83 raviteja83 changed the title [Don't merge] feat: merge reverted changes feat: merge reverted changes Oct 15, 2024
@raviteja83 raviteja83 merged commit efbead5 into dev Oct 15, 2024
4 checks passed
@raviteja83 raviteja83 deleted the fix/WEB-2871-broken-images branch October 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdz-666 hdz-666 hdz-666 approved these changes

@ygit ygit ygit approved these changes

@eswarclynn eswarclynn Awaiting requested review from eswarclynn

@amar-1995 amar-1995 Awaiting requested review from amar-1995

@KaustubhKumar05 KaustubhKumar05 Awaiting requested review from KaustubhKumar05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@raviteja83 @ygit @hdz-666 @amar-1995 @KaustubhKumar05 @eswarclynn