Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix safari v13 support #3218

Merged
merged 6 commits into from
Sep 3, 2024
Merged

chore: fix safari v13 support #3218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
5c3a476
fix: browser support code change
KaustubhKumar05 Sep 3, 2024
5a548bb
fix: browser support code change
KaustubhKumar05 Sep 3, 2024
f17feb4
fix: update build script
KaustubhKumar05 Sep 3, 2024
75956fe
fix: update build script
KaustubhKumar05 Sep 3, 2024
4bf9226
fix: update build script
KaustubhKumar05 Sep 3, 2024
79c14d6
fix: update build script
KaustubhKumar05 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/hls-stats/src/adapters/BaseAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 3,11 @@ import { HlsPlayerStats } from '../interfaces';
export abstract class BaseAdapter {
hlsInstance: Hls;
videoEl: HTMLVideoElement;
hlsStatsState: HlsPlayerStats = {};
hlsStatsState: HlsPlayerStats;
constructor(hlsInstance: Hls, videoEl: HTMLVideoElement) {
this.hlsInstance = hlsInstance;
this.videoEl = videoEl;
this.hlsStatsState = {};
}
abstract startGatheringStats(): void;
abstract finishGatheringStats(): void;
Expand Down
3 changes: 2 additions & 1 deletion packages/roomkit-react/src/Prebuilt/common/PeersSorter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 7,14 @@ class PeersSorter {
lruPeers: Set<HMSPeerID>;
tilesPerPage!: number;
speaker?: HMSPeer;
listeners: Set<(peers: HMSPeer[]) => void> = new Set();
listeners: Set<(peers: HMSPeer[]) => void>;

constructor(store: IStoreReadOnly<any>) {
this.store = store;
this.peers = new Map();
this.lruPeers = new Set();
this.speaker = undefined;
this.listeners = new Set();
}

setPeersAndTilesPerPage = ({ peers, tilesPerPage }: { peers: HMSPeer[]; tilesPerPage: number }) => {
Expand Down
5 changes: 4 additions & 1 deletion packages/roomkit-react/src/Prebuilt/plugins/CaptionsViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 144,10 @@ class Queue {
}

class CaptionMaintainerQueue {
captionData: Queue = new Queue();
captionData: Queue;
constructor() {
this.captionData = new Queue();
}
push(data: HMSTranscript[] = []) {
data.forEach((value: HMSTranscript) => {
this.captionData.enqueue(value);
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-webapp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 18,7 @@ async function main() {
const external = [...Object.keys(pkg.dependencies || {}), ...Object.keys(pkg.peerDependencies || {})];
const loader = { '.js': 'jsx', '.svg': 'dataurl', '.png': 'dataurl' };
const define = { 'process.env': JSON.stringify(process.env) };
const target = 'es6';
const target = ['safari11', 'es6'];
const plugins = [
PostCssPlugin.default({
plugins: [autoprefixer],
Expand Down
2 changes: 1 addition & 1 deletion scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 30,7 @@ async function main() {
const commonOptions = {
entryPoints: source,
bundle: true,
target: 'es6',
target: ['safari11', 'es6'],
external,
tsconfig: 'tsconfig.json',
minify: true,
Expand Down
Loading