Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable VB for older safari versions #3117

Merged
merged 25 commits into from
Aug 5, 2024
Merged

fix: disable VB for older safari versions #3117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift click to select a range
2369110
fix: use hmsvb for older safari versions
KaustubhKumar05 Jul 23, 2024
584ae51
fix: add lib to compare semver
KaustubhKumar05 Jul 23, 2024
be5e503
fix: hmsvb for safari
KaustubhKumar05 Jul 23, 2024
c089204
fix: hmsvb flow
KaustubhKumar05 Jul 28, 2024
c20aad1
fix: type usage
KaustubhKumar05 Jul 28, 2024
a5ec2d4
fix: log security error
KaustubhKumar05 Jul 28, 2024
9832e50
fix: clean up
KaustubhKumar05 Jul 28, 2024
d7ca3ef
fix: types
KaustubhKumar05 Jul 28, 2024
4976584
Merge branch 'dev' into fix/WEB-2925-effects-safari-securityerror
KaustubhKumar05 Jul 29, 2024
c494b36
Merge branch 'dev' into fix/WEB-2925-effects-safari-securityerror
KaustubhKumar05 Jul 29, 2024
dae5ed8
Merge branch 'dev' into fix/WEB-2925-effects-safari-securityerror
KaustubhKumar05 Jul 29, 2024
0d055ff
fix: loader
KaustubhKumar05 Jul 30, 2024
ccc8eea
Merge branch 'dev' into fix/WEB-2925-effects-safari-securityerror
KaustubhKumar05 Jul 31, 2024
cd9611e
fix: update sinks after process plugin:
raviteja83 Jul 31, 2024
65f3927
fix: cleanup
KaustubhKumar05 Jul 31, 2024
f175228
fix: flag for vb
KaustubhKumar05 Jul 31, 2024
da3d985
Merge branch 'dev' into fix/WEB-2925-effects-safari-securityerror
KaustubhKumar05 Jul 31, 2024
1b9abe7
fix: clean up
KaustubhKumar05 Jul 31, 2024
8dfa1a8
fix: conflicts
KaustubhKumar05 Jul 31, 2024
f0cddeb
fix: clean up
KaustubhKumar05 Aug 1, 2024
05ab9c8
fix: import
KaustubhKumar05 Aug 1, 2024
4c4421e
fix: update isblursupported check
KaustubhKumar05 Aug 1, 2024
f965a82
Merge branch 'dev' into fix/WEB-2925-effects-safari-securityerror
KaustubhKumar05 Aug 1, 2024
e373782
Merge branch 'dev' into fix/WEB-2925-effects-safari-securityerror
KaustubhKumar05 Aug 2, 2024
11b5bb1
Merge branch 'dev' into fix/WEB-2925-effects-safari-securityerror
raviteja83 Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: loader
  • Loading branch information
@KaustubhKumar05
KaustubhKumar05 committed Jul 30, 2024
commit 0d055ffbcfaca71adaafac56c7228e86aa34788d
1 change: 0 additions & 1 deletion packages/roomkit-react/src/Prebuilt/components/VirtualBackground/VBHandler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 19,6 @@ export class VBPlugin {
this.effectsPlugin = new HMSEffectsPlugin(effectsSDKKey, onInit);
} else {
this.hmsPlugin = new HMSVBPlugin(HMSVirtualBackgroundTypes.NONE, HMSVirtualBackgroundTypes.NONE);
onInit?.();
}
};

Expand Down
3 changes: 2 additions & 1 deletion packages/roomkit-react/src/Prebuilt/components/VirtualBackground/VBPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 62,8 @@ export const VBPicker = ({ backgroundMedia = [] }: { backgroundMedia: VirtualBac
if (!track?.id) {
return;
}
if (!isPluginAdded) {
const vbObject = VBHandler.getVBObject();
if (!isPluginAdded && !vbObject) {
setLoadingEffects(true);
let vbObject = VBHandler.getVBObject();
if (!vbObject) {
Expand Down
Loading