Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move u256 to proptest #631

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Move u256 to proptest #631

merged 4 commits into from
Mar 27, 2020

Conversation

z2trillion
Copy link
Contributor

  • Tag the PR with wip while in development.
  • Assign yourself as to the PR
  • Assign relevant labels such as bug, enhancement.
  • Request reviews if the PR is large, complex or you would like an extra pair of eyes to go over it.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the Changelog.md.
  • Update version numbers as needed.

Semver: https://github.com/rust-lang/rfcs/blob/master/text/1105-api-evolution.md

https://semver.org/

recmo
recmo suggested changes Mar 26, 2020
View reviewed changes
algebra/primefield/src/test.rs Show resolved Hide resolved
algebra/u256/Cargo.toml Show resolved Hide resolved
algebra/u256/src/additive.rs Show resolved Hide resolved
algebra/u256/src/u256.rs Show resolved Hide resolved
@z2trillion z2trillion requested a review from recmo March 27, 2020 17:09
@z2trillion z2trillion merged commit 2fb5711 into master Mar 27, 2020
@z2trillion z2trillion deleted the mason/proptest branch March 27, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@recmo recmo recmo approved these changes

@aleph-v aleph-v Awaiting requested review from aleph-v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z2trillion @recmo