e2e integration tests with docker and testcontainers #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.82% // Head: 88.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## development #753 /- ##
===============================================
- Coverage 92.82% 88.23% -4.60%
===============================================
Files 41 41
Lines 4644 4794 150
===============================================
- Hits 4311 4230 -81
- Misses 264 494 230
- Partials 69 70 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
0xERR0R
force-pushed
the
e2e-tests
branch
2 times, most recently
from
87e9200 to
b66c78a
Compare
0xERR0R
changed the title
0xERR0R
force-pushed
the
e2e-tests
branch
7 times, most recently
from
ec9902a to
cc43736
Compare
|
Looks very nice. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to introduce first step end-to-end integration tests. We do already have good basic unit test coverage, but I think we should also test more complex scenarios with real running system and external dependencies.
Basic idea:
I created a project DNS MOKKA which can be used as external upstream DNS server. This tool returns predefined answers (DNS responses, DNS errors or answers with delay), so it is easy to assert results.
This PR adds basic tests with all external services (mostly only happy path).
Tests can be execution with
make e2e-testGitHub action executes all e2e-tests on each push and PR
Opinions, ideas and suggestions are welcome 🤝