Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds user customizable DoH upstream user agent #525

Merged
merged 2 commits into from
May 18, 2022

Conversation

FileGo
Copy link
Collaborator

@FileGo FileGo commented May 17, 2022

Adds a new top-level configuration option dohUserAgent, as discussed in #518 and #446.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #525 (f22c4f1) into development (4690ed8) will decrease coverage by 1.17%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #525       /-   ##
===============================================
- Coverage        94.90%   93.73%   -1.18%     
===============================================
  Files               36       36              
  Lines             3104     3112        8     
===============================================
- Hits              2946     2917      -29     
- Misses             109      145       36     
- Partials            49       50        1     
Impacted Files Coverage Δ
config/config.go 98.13% <ø> (ø)
resolver/upstream_resolver.go 91.03% <100.00%> (ø)
redis/redis.go 66.44% <0.00%> (-24.35%) ⬇️
server/server.go 85.81% <0.00%> ( 0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4690ed8...f22c4f1. Read the comment docs.

config/config.go Outdated Show resolved Hide resolved
@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label May 18, 2022
@0xERR0R 0xERR0R added this to the 0.19 milestone May 18, 2022
@0xERR0R
Copy link
Owner

0xERR0R commented May 18, 2022

Thanks you, good work! 👍 🤝

@0xERR0R 0xERR0R merged commit 776c51f into 0xERR0R:development May 18, 2022
@FileGo FileGo deleted the custom_user_agent branch May 18, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants