Defining env var for configurable config file location #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #473 /- ##
============================================
Coverage 94.57% 94.57%
============================================
Files 35 35
Lines 2763 2763
============================================
Hits 2613 2613
Misses 115 115
Partials 35 35 Continue to review full report at Codecov.
|
|
Thanks, is very useful 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying blocky in my environment, I had wanted to use a NFS volume to externalize the config file. However this is not possible when the executable is in the same directory the config file is in. Making the config file location a variable allows this.
The edge case arises as NFS can only mount filesystems instead of individual files. If you mount the volume into the /app directory of the container, this overrides the existing content (the blocky executable) causing the container to fail to start.