Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomDNS: parameter "filterUnmappedTypes" to allow/disable forwarding to the upstream resolver #467

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Mar 22, 2022

New parameter "filterUnmappedTypes" (default true). If set to "false", it will forward queries with unmapped type (TXT, MX etc) to the upstream resolver.

Fixes #461

@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Mar 22, 2022
@0xERR0R 0xERR0R added this to the 0.19 milestone Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #467 (97c4b4b) into development (07f0d1f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #467       /-   ##
===============================================
  Coverage        94.06%   94.07%    0.01%     
===============================================
  Files               35       35              
  Lines             2780     2786        6     
===============================================
  Hits              2615     2621        6     
  Misses             125      125              
  Partials            40       40              
Impacted Files Coverage Δ
config/config.go 88.51% <ø> (ø)
resolver/custom_dns_resolver.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07f0d1f...97c4b4b. Read the comment docs.

@0xERR0R 0xERR0R merged commit 2bb2f97 into development Mar 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the filterUnmappedTypes branch March 22, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customDNS interferes with TXT records
1 participant