Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add API endpoint to flush the DNS Cache #1178

Merged
merged 1 commit into from
Sep 30, 2023
Merged

feat: add API endpoint to flush the DNS Cache #1178

merged 1 commit into from
Sep 30, 2023

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Sep 30, 2023

closes #541

@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Sep 30, 2023
@0xERR0R 0xERR0R added this to the v0.23 milestone Sep 30, 2023
@0xERR0R 0xERR0R enabled auto-merge (squash) September 30, 2023 19:41
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
api/api_interface_impl.go 93.15% <100.00%> ( 0.50%) ⬆️
cache/expirationcache/prefetching_cache.go 100.00% <100.00%> (ø)
cmd/blocking.go 86.81% <100.00%> ( 2.65%) ⬆️
cmd/lists.go 88.00% <100.00%> (-2.00%) ⬇️
cmd/root.go 65.71% <100.00%> ( 4.42%) ⬆️
cmd/cache.go 87.50% <87.50%> (ø)
resolver/caching_resolver.go 94.56% <0.00%> (-1.57%) ⬇️
server/server_endpoints.go 87.87% <40.00%> (-1.11%) ⬇️

📢 Thoughts on this report? Let us know!.

@@ -57,7 56,12 @@ func (s *Server) createOpenAPIInterfaceImpl() (impl api.StrictServerInterface, e
return nil, fmt.Errorf("no refresh API implementation found %w", err)
}

return api.NewOpenAPIInterfaceImpl(bControl, s, refresher), nil
cacheControl, err := resolver.GetFromChainWithType[api.CacheControl](s.queryResolver)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't clear the bootstrap cache. I don't think that's really necessary, but just wanted to make note of it in case you want to document/implement it.

@0xERR0R 0xERR0R merged commit d77f0ed into main Sep 30, 2023
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cache-api branch September 30, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add API endpoint to flush the DNS Cache
2 participants