-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multiple upstreams for bootstrapDns. #760
Comments
Yes, you're right, you can define only one bootstrap DNS server. It would make sense to allow multiple bootstrap DNS server. Since we allow also the definition of IP addresses (for DoH and DoT): bootstrapDns:
upstream: tcp-tls:dns.example.com
ips:
- 123.123.123.123 we can't just change upstream to a list structure (or comma separated string). I think, we need more complex structure and we should also support current config (to avoid breaking changes). |
Started looking into this. For the config, we should be able to transparently support the old format with something like: bootstrapDns:
- upstream: tcp-tls:dns1.example.com
ips:
- 123.123.123.123
- upstream: tcp-tls:dns2.example.com
ips:
- 456.456.456.456 For the implementation, there's a little refactoring needed, but I don't foresee anything major. The awkward part is that with multiple bootstrap upstreams, we want to race them using |
Thanks for this, @0xERR0R and @ThinkChaos. Any idea, when it will be included in images on dockerhub/GCR? |
The |
Nice, thanks again. |
Correct me if I'm wrong, but it seems now I can define only one upstream for bootstrapDns. In worst case scenario when my upstream is down, blocky won't download filters when started.
Can we have bootstrapDns.upstream as a list, maybe?
The text was updated successfully, but these errors were encountered: