Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possibility to reactivate "question=" in query Log #291

Closed
kwitsch opened this issue Sep 25, 2021 · 2 comments · Fixed by #292
Closed

possibility to reactivate "question=" in query Log #291

kwitsch opened this issue Sep 25, 2021 · 2 comments · Fixed by #292
Assignees
@0xERR0R
Labels
🐞 bug Something isn't working
Milestone
v0.17

Comments

@kwitsch
Copy link
Collaborator

kwitsch commented Sep 25, 2021

I noticed that the queryLog INFO log message has changed in v0.16.
The new format lacks the "question=" block.
This is inconvenient when using the log to fine tune your whitelist.

Tags: v0.15 & fb-inline-lists
INFO query_logging_resolver: query resolved answer=* client_ip=* client_names=* duration_ms=* question=* response_code=* response_reason=*

Tags: v0.16 & latest
INFO queryLog: query resolved answer=* duration_ms=* response_code=* response_reason=*

Is there a possibility to reactivate this block in v0.16?

Currently i only set "logLevel: info" in my config and don"t have an "queryLog:" block included.
@0xERR0R
Copy link
Owner

0xERR0R commented Sep 25, 2021 •
edited
Loading

Hi,
Thanks for reporting. This field is somehow "disappeared" after I introduced the new database logger.

@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Sep 25, 2021
@0xERR0R 0xERR0R added this to the 0.17 milestone Sep 25, 2021
@0xERR0R 0xERR0R self-assigned this Sep 25, 2021
@kwitsch
Copy link
Collaborator Author

kwitsch commented Sep 25, 2021

Thanks a lot for your work and the quick response.

0xERR0R added a commit that referenced this issue Sep 25, 2021
@0xERR0R
added missing field in query log (#291)
aae3be0
@0xERR0R 0xERR0R mentioned this issue Sep 25, 2021
Merged
0xERR0R added a commit that referenced this issue Sep 25, 2021
@0xERR0R
added missing field in query log (#291)
598849e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xERR0R 0xERR0R

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
v0.17
Development

Successfully merging a pull request may close this issue.

added missing field in query log (#291) 0xERR0R/blocky
2 participants
@kwitsch @0xERR0R