-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chrono
instead of time
.
#199
Conversation
This is not the fault of
Why do you need an MSRV that is more than 18 months old? Very few crates have policies that extend that far back (with |
I'm sorry, I was indeed under the impression that this was the fault of
A colleague of mine who was not into Rust at that time once tried to install one of my Rust programs on Debian and failed because his system-installed compiler was too old. I just checked now, and the rustc shipped with stable Debian is 1.63. So I'm trying to preserve MSRV as long as it is not too much effort. |
Essentially, the code I had written relied on the fact that the return type of
I honestly don't understand why they even bother shipping a version so old (it was released two full years ago). |
I also use |
Thanks for your explanation, @jhpratt! |
The crate
time
does not build on Rust 1.80 for versions smaller than 0.3.36: time-rs/time#681Apart from the fact that I do not like packages stopping to build when updating the compiler, updating time to 0.3.36 would require raising MSRV to 1.67, which I do not like.
I found that the
chrono
crate has a lower MSRV, it works fine on all compiler versions I tried, and using it is considerably simpler for my use case, so this PR replacestime
withchrono
.A small side effect of this is that jaq outputs fractional seconds with 6 digits instead of 9 before.