Template talk:Denkmalgeschütztes Objekt Österreich
Wikidata check
[edit]I have added a WikidataCheck to this template. This operates on every category on which the template is transcluded. It looks at the Wikidata item linked from the category, and compares with d:Property:P2951 on Wikidata.
- If the category has no Wikidata item (via sitelink), or if that item does not have P2951 set → Category:Denkmalgeschütztes Objekt Österreich not in Wikidata
- → Either there is no item, or more likely it is not linked to the category ; should be fixed but is somehow boring :)
- → Or the P2951 value is missing from Wikidata, and it should be added
- If the category and its linked item have the same identifier → Category:Denkmalgeschütztes Objekt Österreich same as Wikidata
- → Nothing to do :)
- If the identifiers are not the same → Category:Denkmalgeschütztes Objekt Österreich different from Wikidata
- → It is likely an issue that needs correction ; but could be for various reasons. This needs human investigation.
Hope that helps! FYI @Herzi Pinki, AleXXw, and Braveheart:
Jean-Fred (talk) 18:39, 17 June 2018 (UTC)
- Thanks JF, also CCing @Simon04: . It'll most likely point out the discrepancies that still remain on Wikidata until someone solves them by hand ;-) Braveheart (talk) 18:42, 17 June 2018 (UTC)
- Had a stab at letters A-C and fixed a couple of them. The Check does not really work when there is more than one DOO template on a category, which is the case of many… Jean-Fred (talk) 20:12, 17 June 2018 (UTC)
- @Jean-Frédéric: , is there a way to fix this? There was never a rule that there has to be a 1:1 relationship between ids and commons-categories. Commons categories and WD entries should be aligned with real world entities (e.g. a bridge), while the BDA modelling is to split the bridge by municipality / cadastral community. --Herzi Pinki (talk) 22:54, 18 June 2018 (UTC)
- Had a stab at letters A-C and fixed a couple of them. The Check does not really work when there is more than one DOO template on a category, which is the case of many… Jean-Fred (talk) 20:12, 17 June 2018 (UTC)
Also added a search link to Wikidata on the template, which can help hunt down the Wikidata item. Only did that because in the case of this template it blends in with the existing links ; but feel free to revert if you disagree :) Jean-Fred (talk) 18:47, 17 June 2018 (UTC)
First of all thanks for creating the maintenance categories. We only need the workforce to fix it. Is there a defined timeline to get this in sync and who is the driving force, who is responsible for it, etc.? The mess was created by a bot.
- IMHO there is no need for the ok case: Category:Denkmalgeschütztes Objekt Österreich same as Wikidata.
- Sure ; it is just standard issue, in order to track cases with values on both sides (compared to when there is no local value and the template pulls the ID from Wikidata − which we may not do for DOO). Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- What about Category:Am Wienerberg? Both ids do have corresponding WD entries. Nothing is wrong. It would be helpful to treat the cases with multiple ids differently and the id as missing only if the id is not there (among possibly many).
- See below
- I found about 17 positives in Category:Denkmalgeschütztes Objekt Österreich different from Wikidata, while the rest was false alarm (with more than one id). How can we exclude the false positives from further checks? Furthermore I changed wrong ids for 13 files.
- there were also some cases, where the swedish bot went wrong with the id. (i.g. [1])
- The template operates now (?) also on gallery pages. IMHO this template should not be on gallery pages, but on single images and corresponding object categories. Calling @Johann Jaritz: , as I suspect him to be the main id-contributor to galleries. I would propose not to have the template on galleries at all.
- Yeah, I enabled it on both Category and Gallery NS (not sure why I did that ^^). I would agree that the category should be the main element and not care too much about the gallery. Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- Donnerbrunnen is in Category:Denkmalgeschütztes Objekt Österreich not in Wikidata, why?
- Donnerbrunnen links to d:Q1241870, which has no P2951 set. Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- added the id. Q was a bit of a joke. The name of the category is misleading, Donnerbrunnen was in WD, but not connected. Category:Denkmalgeschütztes Objekt Österreich not found in Wikidata would be a better name nearer to the erronous situation. --Herzi Pinki (talk) 22:40, 19 June 2018 (UTC)
- Donnerbrunnen links to d:Q1241870, which has no P2951 set. Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- we have 264 categories that are both in Category:Denkmalgeschütztes Objekt Österreich different from Wikidata and Category:Denkmalgeschütztes Objekt Österreich same as Wikidata. ??? (The other two combinations find 0 matches, which is ok)
- See below
- Can you please also check, whether the commons category name and the Commons category (P373) on the corresponding WD item do match? Due to renaming of categories these get out of sync.
- It looks like that using P373 as the main way to link to Commons categories is more or less deprecated in favour of sitelinks… Bots have been going around Wikidata copying P373 to sitelink. It’s a constraint more easily done on WD side I think. Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- this causes an unsolvable problem in case there is a gallery entered as a sitelink (it is not possible to have both, the gallery and the category as a sitelink, and the gallery is preferred (for what reason I don't know)). --Herzi Pinki (talk) 22:40, 19 June 2018 (UTC)
- It looks like that using P373 as the main way to link to Commons categories is more or less deprecated in favour of sitelinks… Bots have been going around Wikidata copying P373 to sitelink. It’s a constraint more easily done on WD side I think. Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- Is there a way to find out what images (NS 6) do have wrong ids?
- Images are not linked to Wikidata so we can’t use the Check. :-( Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- Rectory in Pitten (Q38039928) has changed id, but not identity. How to proceed? Historizing Cultural heritage database in Austria ObjektID (P2951) did not help.
- I added ranks. Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- I understand your solution, but consider it as a workaround. Access to historized values should be triggered by current date, not by manually playing around with the rank. Next time someone changes the id (on this or another object), it has to be communicated, checked and (I fear) fixed by someone of a small group of people understanding this. With the rank it will not be possible to enter new value in a single step in advance. --Herzi Pinki (talk) 22:40, 19 June 2018 (UTC)
- I added ranks. Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
best --Herzi Pinki (talk) 23:04, 17 June 2018 (UTC)
- Category:Bäckerkapelle Wolfsberg is listed in Category:Denkmalgeschütztes Objekt Österreich not in Wikidata, but it is Bäckerkapelle Wolfsberg (Q1018936). Commonscat is linked, so what is the reason for false positive? Maybe the gallery with same name creates the problems? --Herzi Pinki (talk) 00:29, 18 June 2018 (UTC)
- Yes, the Check only works through the sitelink. Category:Bäckerkapelle Wolfsberg was not linked through sitelink. The current standard is to use sitelink to the category, and leave the gallery to Commons gallery (P935). Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- Non ? Si ! Oh !!!! Can a bot enforce / fix this? I would have never dared to replace a gallery in the sitelink by a category (error prone in case both have the same name, it's easy to forget the necessary Category: prefix.) As there is only a single category and there can be more than one gallery (e.g. in different languages, focusing on different aspects, etc.), this looks completely sound. But: Commons:Wikidata/de#Sitelinks says indifferently: Only Commons galleries and Commons categories should be sitelinked from Wikidata items. --Herzi Pinki (talk) 22:40, 19 June 2018 (UTC)
- Yes, the Check only works through the sitelink. Category:Bäckerkapelle Wolfsberg was not linked through sitelink. The current standard is to use sitelink to the category, and leave the gallery to Commons gallery (P935). Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
Thanks for Category:Denkmalgeschütztes Objekt Österreich without linked Wikidata:
- Thanks for the suggestion, it is a good improvement :) Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- Category:Engelwirtbrunnen is wrong because of redirects in Denkmalliste are not resolved correctly by the swedish import bot. Redirects with anchors do not cause identity of lemmas.
- I see… Well, the solution is simple: if there is already a Wikidata item for this fountain, update it (with sitelink to the Commons cat, DOO id etc.) ; if not, let’s just create it :) Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- I was hoping that you would tell the bot to fix it. To use precious community resources to run after a misguided bot will not give the productivity boost we expect from bots, but slow down the whole process. A bit unwilling to fix this manually in so many cases. But I feel your template cannot handle the situation as it is. It is erronous anyhow. --Herzi Pinki (talk) 22:40, 19 June 2018 (UTC)
- I see… Well, the solution is simple: if there is already a Wikidata item for this fountain, update it (with sitelink to the Commons cat, DOO id etc.) ; if not, let’s just create it :) Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- same for Plainbrücke (Q14551017) and Category:Figurenbildstock hl. Johannes Nepomuk, Plainbrücke (Salzburg)
- in many cases the linkage is done by setting commons cat entry in WD. This could as well be done by a bot doing regular updates based on the monument lists.
best --Herzi Pinki (talk) 12:58, 18 June 2018 (UTC)
- Category:Ratschkybad is not ok but not listed in one of the maintenance categories. It is completely decoupled, which is the worst case (but no complaints about). --Herzi Pinki (talk) 13:10, 18 June 2018 (UTC)
- Not sure I get it: is it a monument? The 25615 one? If so, any particular reason why it does not have {{Doo}}? Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- the problem is, that ALL the ids have been added manually to categories. Of course - with 38000 objects - this can never be completely error free (to my dissatisfaction I also found yesterday some wrong ids set by myself). So I thought whether your template could provide a concise check. --Herzi Pinki (talk) 22:40, 19 June 2018 (UTC)
- Not sure I get it: is it a monument? The 25615 one? If so, any particular reason why it does not have {{Doo}}? Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- Category:Plague Column, Vienna is listed in Category:Denkmalgeschütztes Objekt Österreich without linked Wikidata, as the mechanism seems to handle category redirects incorrectly. It is linked via category redirect and there should be a notification to the one who renamed the category without cleanup or a bot running behind and doing the cleanup. --Herzi Pinki (talk) 15:59, 18 June 2018 (UTC)
- I guess renames in Commons not being reflected on Wikidata is a problem in general ; but it’s in this case it does not matter: P373 does not work for this, only sitelinks Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
- What is the problem with Category:Herz-Jesu-Kirche (Bregenz), Commons category (P373) is set correctly. Same for Category:Herz-Jesu-Kirche, Graz, Category:Power at the sea fountain. It seems that the combination of commons galleries and commons categories on WD is not handled well by the template. --Herzi Pinki (talk) 22:54, 18 June 2018 (UTC)
I answered inline to specific cases, but to emphasize two points:
- This whole only works through d:Help:Sitelinks, not with P373. The reason for this is that sitelinks are two-ways relationships: a Commons category "knows" it’s being linked via sitelink, it "does not know" it is linked via P373 (not directly anyways, I understand there are other ways to achieve that). Given the recent push with {{Wikidata infobox}}, sitelinks have become the de-facto standard.
- Several {{Doo}} templates on one page: unfortunately I don’t think there is any way to solve this.
- The Check currently does not process multiple IDs very well (although it kind of does, but that should be tested more). For French monuments, we designed {{Mérimée}} to be able to have more than one ID − so in theory we could compare all values. However…
- …having more than one template makes it impossible. The Check is embedded into the template, and the template only knows about its parameter. There is no way the check can realise another ID is being used on the same page.
I do realise the problem you describe (and it’s not specific to Austria − at least in France it’s also often like that):
There was never a rule that there has to be a 1:1 relationship between ids and commons-categories. Commons categories and WD entries should be aligned with real world entities (e.g. a bridge), while the BDA modelling is to split the bridge by municipality / cadastral community.
— Herzi Pinki (talk) 22:54, 18 June 2018 (UTC)
I am not sure what the WD best practice is. I just noticed Pont de la Caille (Q1225147) & Pont de la Caille (Q22968662) − did we decide to go for the 1-1 mapping between Mérimée and Wikidata? @VIGNERON: , would you know about this / have recommendation on how to proceed?
Jean-Fred (talk) 09:07, 19 June 2018 (UTC)
@Jean-Frédéric: Everything here makes me sad. See my answers above. To make this usable and productive the following points should be addressed and fixed before manually fixing the rest:
- the double presence of gallery and category is standard (cannot be nuked), so the check has to handle that correctly.
- If the sitelink must be with the category and not the gallery, this should be enforced somewhere else. If you could enter a request at the appropriate place, this would help.
- the system must allow to set the same id in more than one category / gallery without maintenance entry. Otherwise we end up in a maintenance nightmare with some benevolent users.
Modelling of 1:n and n:1 relationships: I proposed to allow multiple ids to the doo template in the beginning, but did not succeed. Now it's too late to start this. I now the limitations of the mediawiki template mechanism quite well. Alternatively we could put a wrapper around multiple occurences of the id template, but this will have an impact on the automatic and manual update.
My way to go is to replace all ids with the corresponding WD id and retrieve all the ids (different type in some cases: a real world object could be a monument, as well as a natural monument or a piece of public art or listed in the Tiroler Kunstkataster; besides multiple values.) from WD (this will solve the redundancy problem having the same multiple ids on many individual files). For the modelling of the above bridge example (silly, French administration has the same modelling flaws), I will go for modelling real world objects independent from any register. The bridge is a bridge. And put the real world objects modeled by the register (both ends of the bridge) to two pseudo-objects as part of (P361) of the complete bridge, those pseudo objects will only contain the net data from the register and the containment relationship.
But as I said, this topic makes me sad and sadness is not a driving force to be effective. Nevertheless thanks for your initiative to point out the many error cases. --Herzi Pinki (talk) 22:40, 19 June 2018 (UTC)
- @ Commons category (P373): Seems to be maintained by a bot: [2] --Herzi Pinki (talk) 07:36, 20 June 2018 (UTC)
How to deal with a situation where the commons category is already attached to a category object on WD, e.g. Stift Schlägl (Q183474),Category:Stift Schlägl (Q9129621). This seems to be quite a common pattern, see Category:Denkmalgeschütztes Objekt Österreich not in Wikidata. --Herzi Pinki (talk) 08:00, 22 June 2018 (UTC)
- Aren't those items for categories relics from around 2013? Don't think they serve any particular purpose nowadays. Braveheart (talk) 12:15, 22 June 2018 (UTC)
- Braveheart, do you really think such a vague assumption will help? Don't you have a reliable source for that statement? And how and who to perform the cleanup? --Herzi Pinki (talk) 17:09, 24 June 2018 (UTC)
- Ok, then let me ask more bluntly: What is the purpose of those Wikidata category items? If they don't serve any purpose, we should get rid of them. :-p Braveheart (talk) 20:09, 24 June 2018 (UTC)
- Braveheart, do you really think such a vague assumption will help? Don't you have a reliable source for that statement? And how and who to perform the cleanup? --Herzi Pinki (talk) 17:09, 24 June 2018 (UTC)
@Jean-Frédéric: things are stuck here. How to deal with Wikidata entries, that have a gallery in the sitelink and not the category your implementation of the check is expecting? --Herzi Pinki (talk) 22:28, 16 January 2019 (UTC)