Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(764)

Issue 7782044: SkTextToPathIter to respect linearText flag.

Can't Edit
Can't Publish Mail
Start Review
Created:
11 years, 6 months ago by bungeman
Modified:
11 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

SkTextToPathIter to respect linearText flag.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats ( 1 line, -2 lines) Patch
M src/core/SkPaint.cpp View 2 chunks 1 line, -2 lines 0 comments Download

Messages

Total messages: 4
bungeman
All other uses of SkPaint::kCanonicalTextSizeForPaths in SkPaint are guarded by a check of isLinearText. It ...
11 years, 6 months ago (2013-03-13 16:16:20 UTC) #1
reed1
lgtm
11 years, 6 months ago (2013-03-13 16:33:33 UTC) #2
bungeman
On 2013/03/13 16:33:33, reed1 wrote: > lgtm The difficulty with landing this is that Chromium's ...
11 years, 6 months ago (2013-03-19 21:23:09 UTC) #3
bungeman
11 years, 6 months ago (2013-03-25 17:23:05 UTC) #4
On 2013/03/19 21:23:09, bungeman wrote:
> On 2013/03/13 16:33:33, reed1 wrote:
> > lgtm
> 
> The difficulty with landing this is that Chromium's HarfBuzz implementation is
> using this to find attachment points. The current attachment points are wrong,
> and with this change they may be somewhat less wrong, but they are still
> incorrect. We may need a better fix.

An additional problem (on the WebKit side) is that the TrueType points do not
1:1 correspond to the SkPath points, as SkPath adds the interpolated on-curve
points of quad segments.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b