Issue 6720050: state, uniter, firewaller: new unit watcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> s or <Ctrl> Enter :	save comment
<Esc> :	cancel edit

Issue 6720050: state, uniter, firewaller: new unit watcher

Can't Edit
Can't Publish Mail
Start Review

Created:
11 years, 11 months ago by aram

Modified:
11 years, 11 months ago

Reviewers:
niemeyer, mp 130161

Visibility:
Public.

Description

state, uniter, firewaller: new unit watcher Convert the unit watcher to a new style watcher that returns only names and refactor the firewaller and uniter to make use of it. https://code.launchpad.net/~aramh/juju-core/111-all-watchers-unit6/ merge/130161 Requires: https://code.launchpad.net/~aramh/juju-core/110-all-watchers-service6/ merge/130154 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state, uniter, firewaller: new unit watcher #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats ( 79 lines, -136 lines)			Patch
A	[revision details]	View	1 chunk	2 lines, -0 lines	0 comments	Download
M	state/unit_test.go	View	1 chunk	18 lines, -65 lines	0 comments	Download
M	state/watcher.go	View	2 chunks	47 lines, -67 lines	0 comments	Download
M	worker/firewaller/firewaller.go	View	1 chunk	8 lines, -3 lines	0 comments	Download
M	worker/uniter/filter.go	View	1 chunk	4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Please propose again when the pre-req is sorted out.

Expand All Messages | Collapse All Messages