Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1011)

Issue 5710054: Encapsulate the final cleanup of the scaler rec into its own function, and

Can't Edit
Can't Publish Mail
Start Review
Created:
12 years, 8 months ago by reed1
Modified:
12 years, 8 months ago
Reviewers:
bungeman
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Encapsulate the final cleanup of the scaler rec into its own function, and call it *after* the paint tweaks fields (like MaskFormat due to maskfilters)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats ( 18 lines, -0 lines) Patch
M include/core/SkScalerContext.h View 1 chunk 2 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks 16 lines, -0 lines 1 comment Download

Messages

Total messages: 2
reed1
12 years, 8 months ago (2012-03-01 21:35:49 UTC) #1
bungeman
12 years, 8 months ago (2012-03-01 22:07:45 UTC) #2
update rec later
the desc already written
information lost

http://codereview.appspot.com/5710054/diff/1/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

http://codereview.appspot.com/5710054/diff/1/src/core/SkPaint.cpp#newcode1635
src/core/SkPaint.cpp:1635: SkScalerContext::PostMakeRec(&rec);
This is too late! Needs to go before 1622 or the changes made to the rec will
never end up in the desc. Good thing you wrote the test code below or I wouldn't
have seen this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b