Issue 5311080: restrict rasterclip based on device needs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> s or <Ctrl> Enter :	save comment
<Esc> :	cancel edit

Issue 5311080: restrict rasterclip based on device needs

Can't Edit
Can't Publish Mail
Start Review

Created:
12 years, 11 months ago by reed1

Modified:
12 years, 11 months ago

Reviewers:
bungeman, Steve VanDeBogart, vandebo (use chromium instead), bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats ( 75 lines, -4 lines)			Patch
M	include/core/SkCanvas.h	View	1 chunk	3 lines, -0 lines	0 comments	Download
M	include/core/SkDevice.h	View	1 chunk	24 lines, -0 lines	1 comment	Download
M	include/gpu/SkGpuDevice.h	View	1 chunk	2 lines, -0 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	7 chunks	38 lines, -4 lines	0 comments	Download
M	src/core/SkDevice.cpp	View	1 chunk	4 lines, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 chunk	4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sounds good to me.

http://codereview.appspot.com/5311080/diff/1/include/core/SkDevice.h
File include/core/SkDevice.h (right):

http://codereview.appspot.com/5311080/diff/1/include/core/SkDevice.h#newcode283
include/core/SkDevice.h:283: enum RasterClipNeeds {
You are converting these values to another set of values.  Maybe it would make
sense to do something like:

enum RasterClipNeeds {
  kClipToBW_RasterClipNeeds = 0x1,
  kClipToBounds_RasterClipNeeds = 0x2,

  kBounds_RasterClipNeeds = 0x3,
  kRegion_RasterClipNeeds = 0x1,
  kAAClip_RasterClipNeeds = 0x0,
};

Expand All Messages | Collapse All Messages