Issue 432: Batch request with null callback throws exception

Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs

 /*
 Copyright 2013 Google Inc
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
 http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
@@ skipping 193 matching lines @@
 ""code"": 404,
 ""message"": ""Not Found""
 }
 }";
 bool successful2ndResponse;
 public BatchMessageHandler(bool successful2ndReponse = true)
 {
 this.successful2ndResponse = successful2ndReponse;
 }
 
- protected override async Task<HttpResponseMessage> SendAsyncCore(Htt
 pRequestMessage request,
+ protected override Task<HttpResponseMessage> SendAsyncCore(HttpReque
 stMessage request,

[class, 2014/01/06 17:06:47]

Will this still execute asynchronously?

[peleyal, 2014/01/06 21:43:13]

there isn't a call to await so declaring the method as async is unnecessary.
This method will be called as part of HttpClient messaging so it will be async.
On 2014/01/06 17:06:47, class wrote:

[class, 2014/01/07 00:49:20]

ack.
On 2014/01/06 21:43:13, peleyal wrote:

 CancellationToken cancellationToken)
 {
 #region Verify Request Message
 
 var contentType = request.Content.Headers.ContentType;
 Assert.AreEqual("multipart/mixed", contentType.MediaType.ToStrin
g());
 Assert.That(contentType.Parameters.Count, Is.EqualTo(1));
 Assert.That(contentType.Parameters.First().ToString().StartsWith
("boundary="),
 "Parameter should start with boundary=");
 var boundary = contentType.Parameters.First().ToString().Substri
ng("boundary=".Length).
 Replace("\"", "");
 var expectedContent = ExpectedContentMessage.Replace("BOUNDARY",
boundary);
 var actuallContent = request.Content.ReadAsStringAsync().Result;
 Assert.That(actuallContent, Is.EqualTo(expectedContent));
 
 #endregion
 
 HttpResponseMessage response = new HttpResponseMessage();
 // Response contains 2 responses. The second one is successful b
ased on the constructor's parameter.
 var content = ResponseContent.Replace("BOUNDARY", boundary).Repl
ace("SECOND_RESPONSE",
 successful2ndResponse ? SuccessfulResponse : UnsuccessfulRes
ponse);
 response.Content = new StringContent(content,
 Encoding.UTF8, "multipart/mixed");
 response.Content.Headers.ContentType.Parameters.Add(new NameValu
eHeaderValue("boundary", boundary));
 
- return response;
+ TaskCompletionSource<HttpResponseMessage> tcs = new TaskCompleti
 onSource<HttpResponseMessage>();
+ tcs.SetResult(response);
+ return tcs.Task;
 }
 }
 
 [Test]
 public void ExecuteAsync_Test()
 {
 SubtestExecuteAsync_Test(true);
 }
 
 [Test]
@@ skipping 65 matching lines @@
 Assert.That(reqError.Code, Is.EqualTo(404));
 Assert.That(reqError.Message, Is.EqualTo("Not Found"));
 }
 httpMessage = tuple.Item3; // HTTP message
 Assert.That(httpMessage.Content.Headers.ContentType.MediaType, I
s.EqualTo("application/json"));
 Assert.That(httpMessage.Content.Headers.ContentLength, Is.EqualT
o(202));
 }
 }
 
 [Test]
+public void ExecuteAsync_NoCallback_Test()
+{
+var handler = new BatchMessageHandler(true);
+var initializer = new BaseClientService.Initializer()
+{
+HttpClientFactory = new MockHttpClientFactory(handler)
+};
+
+using (var service = new MockClientService(initializer, "http://samp
le.com"))
+{
+var responses = new List<Tuple<MockResponse, RequestError, HttpR
esponseMessage>>();
+var batch = new BatchRequest(service);
+var request1 = new TestClientServiceRequest(service, new MockReq
uest
+{
+ETag = "\"100\"",
+Name = "Name1"
+});
+var request2 = new TestClientServiceRequest(service, new MockReq
uest
+{
+ETag = "\"200\"",
+Name = "Name1-1"
+});
+batch.Queue<MockResponse>(request1, null);
+batch.Queue<MockResponse>(request2, null);
+batch.ExecuteAsync().Wait();
+}
+}
+
+[Test]
 public void CreateOuterRequestContent_Test()
 {
 using (var service = new MockClientService("http://sample.com"))
 {
 var request1 = new TestClientServiceRequest(service, new MockReq
uest
 {
 ETag = "\"100\"",
 Name = "Name1"
 });
 var request2 = new TestClientServiceRequest(service, new MockReq
uest
@@ skipping 53 matching lines @@
 var request = new HttpRequestMessage(HttpMethod.Get, "http://test.co
m:2020");
 request.Content = new StringContent("hello world");
 request.Headers.AcceptEncoding.Add(new StringWithQualityHeaderValue(
"gzip"));
 request.Content.Headers.ContentType = new MediaTypeHeaderValue("appl
ication/json");
 
 var requestStr = BatchRequest.CreateRequestContentString(request).Re
sult;
 Assert.AreEqual(expectedMessage, requestStr);
 }
 }
 }