LGTM Approve w/ minor edit below. I emailed peleyal with verification that the error is caught ...
9 years, 9 months ago
(2014-12-19 05:32:05 UTC)
#2
LGTM Approve
w/ minor edit below.
I emailed peleyal with verification that the error is caught and displayed
correctly if service accounts are not enabled.
https://codereview.appspot.com/186470043/diff/40001/Src/GoogleApis.Auth/OAuth...
File Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs (right):
https://codereview.appspot.com/186470043/diff/40001/Src/GoogleApis.Auth/OAuth...
Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs:85: var error = "Server response
doesn't contain a TokenErrorResponse JSON object. Status code is: "
suggest changing error text from
doesn't contain a TokenErrorResponse JSON object
to
does not contain a JSON object
Issue 186470043: ComputeCredential - improve logging and throw a better exception
(Closed)
Created 9 years, 9 months ago by peleyal
Modified 9 years, 9 months ago
Reviewers: srashid, salrashid123
Base URL: https://google-api-dotnet-client.googlecode.com/hg/
Comments: 2