Issue 361: MediaDownloader can't download drive export list (which includes query parameters)

Src/GoogleApis/Apis/Http/ConfigurableMessageHandler.cs

 /*
 Copyright 2013 Google Inc
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
 http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
@@ skipping 74 matching lines @@
 #endregion
 
 /// <summary> Number of tries. Default is <c>3</c>. </summary>
 private int numTries = 3;
 
 /// <summary>·
 /// Gets or sets the number of tries that will be allowed to execute. Re
tries occur as a result of either
 /// <see cref="IHttpUnsuccessfulResponseHandler"/> or <see cref="IHttpEx
ceptionHandler"/> which handles the
 /// abnormal Http response or exception, before being terminated.·
 /// Set <c>1</c> for not retrying requests. The default value is <c>3</c
>".
+/// <remarks>
+/// The number of allowed redirects (3xx) is defined by <seealso cref="N
umRedirects"/>. This property defines
+/// only the allowed tries for >=400 responses, or in a case an exceptio
n was thrown. For example you set·
+/// <see cref="NumTries"/> to 1 and <see cref="NumRedirect"/> to 5, a re
try will happen only for 5 redirects.

[ngmiceli, 2013/10/14 19:27:10]

Try to be as explicit as possible. Here's what we came up with together:
"to 5, the library will send up to five redirect requests, but will not send any
retry requests due to an error HTTP status code."

+/// </remarks>
 /// </summary>
 public int NumTries
 {
 get { return numTries; }
 set
 {
 if (value > MaxAllowedNumTries || value < 1)
 {
 throw new ArgumentOutOfRangeException("NumTries");
 }
 numTries = value;
 }
 }
 
+/// <summary> Number of redirects allowed. Default is <c>10</c>. </summa
ry>
+private int numRedirect = 10;
+
+/// <summary>·
+/// Gets or sets the number of redirects that will be allowed to execute
. The default value is <c>10</c>.
+/// See <see cref="NumTries"/> for more information.
+/// </summary>
+public int NumRedirects
+{
+get { return numRedirect; }
+set
+{
+if (value > MaxAllowedNumTries || value < 1)
+{
+throw new ArgumentOutOfRangeException("NumRedirects");
+}
+numRedirect = value;
+}
+}
+
 /// <summary>·
 /// Gets or sets whether the handler should follow a redirect when a red
irect response is received. Default·
 /// value is <c>true</c>.
 /// </summary>
 public bool FollowRedirect { get; set; }
 
 /// <summary> Gets or sets whether logging is enabled. Default value is
<c>true</c>. </summary>
 public bool IsLoggingEnabled { get; set; }
 
 /// <summary> Gets or sets the application name which will be used on th
e User-Agent header. </summary>
@@ skipping 12 matching lines @@
 /// The main logic of sending a request to the server. This send method
adds the User-Agent header to a request
 /// with <see cref="ApplicationName"/> and the library version. It also
calls interceptors before each attempt,
 /// and unsuccessful response handler or exception handlers when abnorma
l response or exception occurred.
 /// </summary>
 protected override async Task<HttpResponseMessage> SendAsync(HttpRequest
Message request,
 CancellationToken cancellationToken)
 {
 var loggable = IsLoggingEnabled && Logger.IsDebugEnabled;
 
 int triesRemaining = NumTries;
+int redirectRemaining = NumRedirects;
+
 Exception lastException = null;
 
 // set User-Agent header
 var userAgent = (ApplicationName == null ? "" : ApplicationName "
") UserAgentSuffix;
 // TODO: setting the User-Agent won't work on Silverlight. We may ne
ed to create a special callback here to·
 // set it correctly. Also check what happen in WP?
 request.Headers.Add("User-Agent", userAgent);
 
 HttpResponseMessage response = null;
 do // while (triesRemaining > 0)
@@ skipping 19 matching lines @@
 {
 // send the request!
 response = await base.SendAsync(request, cancellationToken).
ConfigureAwait(false);
 }
 catch (Exception ex)
 {
 lastException = ex;
 }
 
 // decrease the number of retries
- triesRemaining--;
+ if (response == null || (int)response.StatusCode >= 400)
+ {
+  triesRemaining--;
+ }
 
 // exception was thrown , try to handle it
 if (response == null)
 {
 var exceptionHandled = false;
 
 // try to handle the exception with each handler
 foreach (var handler in exceptionHandlers)
 {
 exceptionHandled |= handler.HandleException(new HandleEx
ceptionArgs
@@ skipping 39 matching lines @@
 TotalTries = NumTries,
 CurrentFailedTry = NumTries - triesRemaining
,
 CancellationToken = cancellationToken
 });
 }
 
 if (!errorHandled)
 {
 if (HandleRedirect(response))
 {
+if (redirectRemaining-- == 0)
+{
+triesRemaining = 0;
+}
+
 errorHandled = true;
 if (loggable)
 {
 Logger.Debug("Redirect response was handled
successfully. Redirect to {0}",
 response.Headers.Location);
 }
 }
 else
 {
 if (loggable)
@@ skipping 56 matching lines @@
 request.Headers.Remove("Authorization");
 request.Headers.IfMatch.Clear();
 request.Headers.IfNoneMatch.Clear();
 request.Headers.IfModifiedSince = null;
 request.Headers.IfUnmodifiedSince = null;
 request.Headers.Remove("If-Range");
 return true;
 }
 }
 }