Issues 373 (Execute Bug), 374 (Remove Tests.Utility) and 375 (Clean warnings)

Src/GoogleApis/Apis/Requests/ClientServiceRequest.cs

 /*
 Copyright 2011 Google Inc
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
 http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
@@ skipping 72 matching lines @@
 
 public TResponse Execute()
 {
 try
 {
 using (var response = ExecuteUnparsed(CancellationToken.None).Re
sult)
 {
 return ParseResponse(response).Result;
 }
 }
- catch (AggregateException ex)
+ catch (AggregateException aex)
 {
 // if an exception was thrown during the tasks, unwrap and throw
it
- throw ex.InnerException;
+ throw aex.InnerException;
+ }
+ catch (Exception ex)
+ {
+ throw ex;
 }
 }
 
 public Stream ExecuteAsStream()
 {
 // TODO(peleyal): should we copy the stream, and dispose the respons
e?
 try
 {
 // sync call
 var response = ExecuteUnparsed(CancellationToken.None).Result;
 return response.Content.ReadAsStreamAsync().Result;
 }
- catch (AggregateException ex)
+ catch (AggregateException aex)
 {
 // if an exception was thrown during the tasks, unwrap and throw
it
- throw ex.InnerException;
+ throw aex.InnerException;
+ }
+ catch (Exception ex)
+ {
+ throw ex;
 }
 }
 
 public async Task<TResponse> ExecuteAsync()
 {
 return await ExecuteAsync(CancellationToken.None).ConfigureAwait(fal
se);
 }
 
 public async Task<TResponse> ExecuteAsync(CancellationToken cancellation
Token)
 {
@@ skipping 25 matching lines @@
 {
 using (var request = CreateRequest())
 {
 return await service.HttpClient.SendAsync(request, cancellationT
oken).ConfigureAwait(false);
 }
 }
 
 /// <summary> Async executes the request without parsing the result. </s
ummary>
 private Task<HttpResponseMessage> ExecuteAsyncUnparsed(CancellationToken
cancellationToken)
 {
+// TODO(peleyal): remove the creation of a new Task (it's not necess
ary).
+// It should also be removed from ResumableMediaUpload and MediaDown
loader!
+
 // create a new task completion source and return its task. In addit
ional task we actually send the request
 // using ExecuteUnparsed and setting the result or the exception on
the completion source
 TaskCompletionSource<HttpResponseMessage> tcs = new TaskCompletionSo
urce<HttpResponseMessage>();
 Task.Factory.StartNew(async () =>
 {
 try
 {
 var response = await ExecuteUnparsed(cancellationToken).
ConfigureAwait(false);
 tcs.SetResult(response);
 }
@@ skipping 207 matching lines @@
 dict.Add(name, value);
 }
 }
 
 return dict;
 }
 
 #endregion
 }
 }