Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4786)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 12767046: Issue 377: New build for releasing a new version (Closed)

Can't Edit
Can't Publish Mail
Start Review
Created:
11 years, 2 months ago by peleyal
Modified:
11 years, 1 month ago
Reviewers:
David waters
CC:
google-api-dotnet-client_googlegroups.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 377: New build for releasing a new version In this CL - I removed all tools projects and created two new ones - Google.Apis.Release and Google.Apis.Utils

Patch Set 1 #

Patch Set 2 : Running step 2. Next commiting and pushing to all repositories - The real test! #

Patch Set 3 : Using this tool to release 1.5.0-beta #

Patch Set 4 : minor #

Patch Set 5 : Hg pull -u #

Patch Set 6 : add comments #

Total comments: 17

Patch Set 7 : self review #

Total comments: 1

Patch Set 8 : minor #

Total comments: 38

Patch Set 9 : self review II #

Patch Set 10 : minor #

Total comments: 32

Patch Set 11 : david comments #

Unified diffs Side-by-side diffs Delta from patch set Stats ( 1590 lines, -2539 lines) Patch
R Tools/BuildRelease/BuildRelease.csproj View 1 chunk 0 lines, -73 lines 0 comments Download
R Tools/BuildRelease/Program.cs View 1 chunk 0 lines, -663 lines 0 comments Download
R Tools/BuildRelease/Properties/AssemblyInfo.cs View 1 chunk 0 lines, -34 lines 0 comments Download
R Tools/BuildRelease/Wiki/DownloadsPage.cs View 1 chunk 0 lines, -104 lines 0 comments Download
R Tools/BuildRelease/app.config View 1 chunk 0 lines, -3 lines 0 comments Download
M Tools/Google.Apis.NuGet.Publisher/Google.Apis.NuGet.Publisher.csproj View 1 2 3 4 2 chunks 6 lines, -3 lines 0 comments Download
M Tools/Google.Apis.NuGet.Publisher/NuGetApiPublisher.cs View 1 2 3 4 5 6 7 8 9 10 1 chunk 1 line, -0 lines 0 comments Download
M Tools/Google.Apis.NuGet.Publisher/Program.cs View 1 2 3 4 5 6 7 8 9 10 1 chunk 1 line, -0 lines 0 comments Download
M Tools/Google.Apis.NuGet.Publisher/Properties/AssemblyInfo.cs View 1 2 3 4 5 6 7 8 1 chunk 17 lines, -1 line 0 comments Download
R Tools/Google.Apis.NuGet.Publisher/TraceExtensions.cs View 1 2 3 4 5 6 7 8 9 10 1 chunk 0 lines, -33 lines 0 comments Download
A Tools/Google.Apis.Release/App.config View 1 chunk 34 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Release/Google.Apis.Release.csproj View 1 2 3 4 5 6 7 8 1 chunk 90 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Release/Program.cs View 1 2 3 4 5 6 7 8 9 10 1 chunk 651 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Release/ProjectExtenstions.cs View 1 2 3 4 5 6 7 8 9 10 1 chunk 85 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Release/Properties/AssemblyInfo.cs View 1 2 3 4 5 6 7 8 1 chunk 52 lines, -0 lines 0 comments Download
M Tools/Google.Apis.Release/Repositories/Hg.cs View 1 2 3 4 5 6 7 8 9 10 9 chunks 86 lines, -167 lines 0 comments Download
A Tools/Google.Apis.Release/Resources/Google.Apis.Authentication.VERSION.nuspec View 1 2 3 4 1 chunk 29 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Release/Resources/Google.Apis.VERSION.nuspec View 1 2 3 4 1 chunk 59 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Release/Resources/License.txt View 1 2 3 4 5 6 7 1 chunk 202 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Release/Wiki/DownloadsPageUpdater.cs View 1 2 3 4 5 6 7 8 9 10 1 chunk 85 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Release/packages.config View 1 chunk 5 lines, -0 lines 0 comments Download
M Tools/Google.Apis.Utils/DirectoryUtilities.cs View 1 2 3 4 5 6 7 8 9 10 2 chunks 3 lines, -1 line 0 comments Download
A Tools/Google.Apis.Utils/Google.Apis.Utils.csproj View 1 2 3 4 5 6 7 8 9 10 1 chunk 70 lines, -0 lines 0 comments Download
M Tools/Google.Apis.Utils/NuGetUtilities.cs View 1 2 3 4 5 6 7 8 9 10 1 chunk 2 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Utils/Properties/AssemblyInfo.cs View 1 2 3 4 5 6 7 8 1 chunk 52 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Utils/Trace/TraceExtensions.cs View 1 2 3 4 5 6 7 8 9 10 1 chunk 31 lines, -0 lines 0 comments Download
A Tools/Google.Apis.Utils/packages.config View 1 chunk 5 lines, -0 lines 0 comments Download
R Tools/Google.Build.Tester/Google.Build.Tester.csproj View 1 chunk 0 lines, -68 lines 0 comments Download
R Tools/Google.Build.Tester/Program.cs View 1 chunk 0 lines, -65 lines 0 comments Download
R Tools/Google.Build.Tester/Properties/AssemblyInfo.cs View 1 chunk 0 lines, -35 lines 0 comments Download
R Tools/Google.Build.Tester/UnitTester.cs View 1 chunk 0 lines, -225 lines 0 comments Download
R Tools/Google.Build.Tester/Utils.cs View 1 chunk 0 lines, -61 lines 0 comments Download
R Tools/Google.Build.Tester/app.config View 1 chunk 0 lines, -3 lines 0 comments Download
R Tools/Google.Build.Utils/Build/Project.cs View 1 chunk 0 lines, -252 lines 0 comments Download
R Tools/Google.Build.Utils/DirUtils.cs View 1 chunk 0 lines, -110 lines 0 comments Download
R Tools/Google.Build.Utils/Extensions.cs View 1 chunk 0 lines, -45 lines 0 comments Download
R Tools/Google.Build.Utils/Google.Build.Utils.csproj View 1 chunk 0 lines, -76 lines 0 comments Download
R Tools/Google.Build.Utils/Properties/AssemblyInfo.cs View 1 chunk 0 lines, -35 lines 0 comments Download
R Tools/Google.Build.Utils/Runner.cs View 1 chunk 0 lines, -140 lines 0 comments Download
R Tools/Google.Build.Utils/Text/Template.cs View 1 chunk 0 lines, -72 lines 0 comments Download
R Tools/Google.Build.Utils/Text/TextUtils.cs View 1 chunk 0 lines, -139 lines 0 comments Download
R Tools/Google.Build.Utils/Zip.cs View 1 chunk 0 lines, -95 lines 0 comments Download
R Tools/Lib/Google.Apis.Samples.Helper.dll View Binary file 0 comments Download
R Tools/Lib/Ionic.Zip.dll View Binary file 0 comments Download
R Tools/Lib/nunit.core.dll View Binary file 0 comments Download
R Tools/Lib/nunit.core.interfaces.dll View Binary file 0 comments Download
M Tools/Tools.sln View 1 2 3 4 4 chunks 24 lines, -36 lines 0 comments Download

Messages

Total messages: 11
peleyal
https://codereview.appspot.com/12767046/diff/14001/Tools/Google.Apis.Release/Program.cs File Tools/Google.Apis.Release/Program.cs (right): https://codereview.appspot.com/12767046/diff/14001/Tools/Google.Apis.Release/Program.cs#newcode155 Tools/Google.Apis.Release/Program.cs:155: } TODO(peleyal): release notes should be part of the ...
11 years, 2 months ago (2013-09-01 22:31:03 UTC) #1
peleyal
11 years, 2 months ago (2013-09-01 22:31:13 UTC) #2
peleyal
https://codereview.appspot.com/12767046/diff/14001/Tools/Google.Apis.Release/Program.cs File Tools/Google.Apis.Release/Program.cs (right): https://codereview.appspot.com/12767046/diff/14001/Tools/Google.Apis.Release/Program.cs#newcode155 Tools/Google.Apis.Release/Program.cs:155: } On 2013/09/01 22:31:03, peleyal wrote: > TODO(peleyal): release ...
11 years, 2 months ago (2013-09-05 15:08:22 UTC) #3
peleyal
https://codereview.appspot.com/12767046/diff/21001/Tools/Google.Apis.Release/Resources/License.txt File Tools/Google.Apis.Release/Resources/License.txt (right): https://codereview.appspot.com/12767046/diff/21001/Tools/Google.Apis.Release/Resources/License.txt#newcode190 Tools/Google.Apis.Release/Resources/License.txt:190: Copyright 2013 Google Inc. Copyright [yyyy] [name of copyright ...
11 years, 2 months ago (2013-09-06 13:34:16 UTC) #4
peleyal
https://codereview.appspot.com/12767046/diff/26001/Tools/Google.Apis.Release/Program.cs File Tools/Google.Apis.Release/Program.cs (right): https://codereview.appspot.com/12767046/diff/26001/Tools/Google.Apis.Release/Program.cs#newcode1 Tools/Google.Apis.Release/Program.cs:1: using System; add Google header https://codereview.appspot.com/12767046/diff/26001/Tools/Google.Apis.Release/Program.cs#newcode36 Tools/Google.Apis.Release/Program.cs:36: "'3' for ...
11 years, 1 month ago (2013-09-14 21:15:14 UTC) #5
peleyal
https://codereview.appspot.com/12767046/diff/26001/Tools/Google.Apis.Release/Program.cs File Tools/Google.Apis.Release/Program.cs (right): https://codereview.appspot.com/12767046/diff/26001/Tools/Google.Apis.Release/Program.cs#newcode1 Tools/Google.Apis.Release/Program.cs:1: using System; On 2013/09/14 21:15:14, peleyal wrote: > add ...
11 years, 1 month ago (2013-09-16 12:33:53 UTC) #6
peleyal
Hi David, I had 2 self reviews, and I feel comfortable with this one. I ...
11 years, 1 month ago (2013-09-16 13:32:13 UTC) #7
David waters
Hi Eyal, Pretty good code just a few thoughts. https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs File Tools/Google.Apis.Release/Program.cs (right): https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode95 Tools/Google.Apis.Release/Program.cs:95: ...
11 years, 1 month ago (2013-09-19 16:22:31 UTC) #8
peleyal
Thanks for the review! Let me know if don't have time for last review, so ...
11 years, 1 month ago (2013-09-20 18:56:17 UTC) #9
David waters
Sorry Eyal, I'm not going to get a chance to look at this this week, ...
11 years, 1 month ago (2013-09-25 09:35:54 UTC) #10
peleyal
11 years, 1 month ago (2013-09-25 12:16:38 UTC) #11 
It's OK. I think I'll review it again, and I'll just commit it.
'Thanks!
On Sep 25, 2013 5:35 AM, "David W" <[email protected]> wrote:

> Sorry Eyal,
> I'm not going to get a chance to look at this this week, Perf   EOQ => Me
> very busy. I'm on leave next week, so I would advise trying to get another
> review to get your Looks Good To Them.
>
> Sorry once more,
> David.
>
>
> On 20 September 2013 19:56, <[email protected]> wrote:
>
>> Thanks for the review!
>>
>> Let me know if don't have time for last review, so I'll just push it.
>>
>> I've not changed a lot, so I'm feeling comfortable to push it without
>> your LGTM.
>>
>> Let me know, have a great wkd!
>> Eyal
>>
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.cs<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs>
>> File Tools/Google.Apis.Release/**Program.cs (right):
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode95<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode95>
>> Tools/Google.Apis.Release/**Program.cs:95: private Hg DefaultRepository {
>> get; set; }
>> I changed it a little bit.
>> It does the job, and we will focus later on, on moving to github so we
>> may remove this piece of code
>>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> If Hg has not changed since I last looked at it ( about a year ago )
>>>
>> it is quite
>>
>>> rubish.
>>> You may wish to do a review of it before using it more.
>>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode120<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode120>
>> Tools/Google.Apis.Release/**Program.cs:120:
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> if(options.Step > 2 || < 1)
>>>    user.tell("Dude! got {0} expecting 1 or 2 ");
>>>
>>
>> Done.
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode157<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode157>
>> Tools/Google.Apis.Release/**Program.cs:157: if (options.Step == 1)
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Consider
>>> if(step 1)
>>> {
>>>    doBaseStep(); // Or better name
>>> } else if(step 2) {
>>>    doApiSteps(); // Or better name
>>> } else {
>>>    user.tell("How the hell did you get here?");
>>> }
>>>
>>
>> Done.
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode164<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode164>
>> Tools/Google.Apis.Release/**Program.cs:164: if (!HasIncomingChanges(new
>> List<Hg> { DefaultRepository }))
>> I hate vargas. I prefer enumerable. That's my style :) enumerable is
>> very easy to use and it supports linq :)
>>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Do vararg parameters in c# allow passing in lists? or just array? if
>>>
>> lists you
>>
>>> might want to
>>>
>>
>>  if(!HasIncomingChagnes(**DefaultRepo))
>>> ...
>>>
>>
>>  private bool HasIncomingChanges(Hg... repos)
>>>
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode168<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode168>
>> Tools/Google.Apis.Release/**Program.cs:168: CreateNuGetPackages();
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> CreateCoreNuGetPackages ?
>>>
>>
>> Done.
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode170<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode170>
>> Tools/Google.Apis.Release/**Program.cs:170: }
>> Actually no necessary cause it will be printed by the HasIcomingChanges
>> and by BuildDefaultRepository if they fail
>>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Good to have else clauses for both these if statments
>>>
>>
>>  else {
>>>    user.Tell("Failed to build default Pacakge");
>>> } else {
>>>    user.Tell("Cant build with outstanding changes");
>>> }
>>>
>>
>>  Please disregard if the methods already warn the user before returning
>>>
>> false.
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode186<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode186>
>> Tools/Google.Apis.Release/**Program.cs:186: if (CanContinue())
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Consider:I would reverse this if condition to reduce nesting.
>>>
>>
>>  if(!CanContinue())
>>> {
>>>    return;
>>> }
>>>
>>
>>
>>  Dito HasIncomingChange
>>>
>>
>> Done.
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode188<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode188>
>> Tools/Google.Apis.Release/**Program.cs:188: SamplesRepository = new
>> Hg(new
>> Uri(string.Format(CloneUrl, ".samples")), "samples");
>> it's actually not null.
>> because that's done before checking in which step we are
>>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Is constructing new Hg expensive?
>>> If not it may be worth doing
>>>
>>
>>  private void Run() {
>>>    initAllRepos();
>>>    if (step 1) ...
>>>
>>
>>  Currently currently DefaultRepository is null so
>>> HasIncomingChanges(**AllRepositories) will not check for incoming
>>>
>> changes in
>>
>>> DefaultRepo.
>>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode255<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode255>
>> Tools/Google.Apis.Release/**Program.cs:255: input = Console.ReadLine();
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> consider:
>>> input = Console.ReadLine().**toLowerCase();
>>>
>>
>> Done.
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Program.**cs#newcode347<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Program.cs#newcode347>
>> Tools/Google.Apis.Release/**Program.cs:347: #region
>> [RELEASE_VERSION]/Generated/**Bin
>> In general I agree with you, but because it's only a tool and not our
>> core library, I'll allow myself to make my life easier here, unless you
>> have a strong opinion....
>>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Consider:I would be inclinded to break these #regions out into
>>>
>> methods.
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/**ProjectExtenstions.cs<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/ProjectExtenstions.cs>
>> File Tools/Google.Apis.Release/**ProjectExtenstions.cs (right):
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/**ProjectExtenstions.cs#**newcode28<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/ProjectExtenstions.cs#newcode28>
>> Tools/Google.Apis.Release/**ProjectExtenstions.cs:28: ///
>> <summary>Project
>> extensions.</summary>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Better doc please.
>>> maybe just
>>>
>>
>>  Extension methods for the Project class
>>>
>>
>>  but if you could add a little detail about what sort of functionality
>>>
>> you are
>>
>>> added it would be good.
>>>
>>
>> Done.
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/**ProjectExtenstions.cs#**newcode29<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/ProjectExtenstions.cs#newcode29>
>> Tools/Google.Apis.Release/**ProjectExtenstions.cs:29: static class
>> ProjectExtenstions
>>
http://msdn.microsoft.com/en-**us/library/ms173121.aspx<http://msdn.microsoft...
>> Internal by the way.
>> Done
>>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> can this class be internal? ( I never remember what the default vis in
>>>
>> c# is.)
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Wiki/**DownloadsPageUpdater.cs<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Wiki/DownloadsPageUpdater.cs>
>> File Tools/Google.Apis.Release/**Wiki/DownloadsPageUpdater.cs (right):
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Wiki/**DownloadsPageUpdater.cs#**newcode22<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Wiki/DownloadsPageUpdater.cs#newcode22>
>> Tools/Google.Apis.Release/**Wiki/DownloadsPageUpdater.cs:**22: ///
>> <summary>Updates the Downloads wiki page. </summary>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> please give live url to page
>>>
>>
>> Done.
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Wiki/**DownloadsPageUpdater.cs#**newcode30<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Wiki/DownloadsPageUpdater.cs#newcode30>
>> Tools/Google.Apis.Release/**Wiki/DownloadsPageUpdater.cs:**30: {
>>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> consider :
>>> workingDirectory.**ThrowIfNullOrEmpty()
>>> dito oldVersion & newVersion
>>>
>>
>> Done.
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Release/Wiki/**DownloadsPageUpdater.cs#**newcode72<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Release/Wiki/DownloadsPageUpdater.cs#newcode72>
>> Tools/Google.Apis.Release/**Wiki/DownloadsPageUpdater.cs:**72:
>> Func<string,
>> string> replaceFunc)
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Consider,
>>> This feels like over-generalization we have twice as many overloads as
>>>
>> calls! :)
>>
>>  I would drop this overload and drop the func.
>>>
>>
>> Done.
>>
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Utils/**TraceExtensions.cs<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Utils/TraceExtensions.cs>
>> File Tools/Google.Apis.Utils/**TraceExtensions.cs (right):
>>
>> https://codereview.appspot.**com/12767046/diff/44001/Tools/**
>>
Google.Apis.Utils/**TraceExtensions.cs#newcode27<https://codereview.appspot.com/12767046/diff/44001/Tools/Google.Apis.Utils/TraceExtensions.cs#newcode27>
>> Tools/Google.Apis.Utils/**TraceExtensions.cs:27: /// <summary>Traces the
>> event using the current thread id.</summary>
>> On 2013/09/19 16:22:32, David waters wrote:
>>
>>> Consider:
>>> I no longer like making extension methods public, cause I did early in
>>>
>> this
>>
>>> project and now regrate it.
>>>
>>
>>  Either keep internal or maybe move into its own namespace so no-one
>>>
>> starts using
>>
>>> this method by accident (inteli-sense).
>>>
>>
>> Done.
>>
>>
https://codereview.appspot.**com/12767046/<https://codereview.appspot.com/127...
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b