Issue 369: Change default behavior of an HTTP request

Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs

 /*
 Copyright 2011 Google Inc
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
 http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
@@ skipping 520 matching lines @@
 Assert.That(handler.Calls, Is.EqualTo(1));
 // the returned response should contain ETag, check that the ser
vice add the right ETag property on·
 // the response
 handler.ResponseObject.ETag = handler.ResponseETag;
 Assert.That(response, Is.EqualTo(handler.ResponseObject));
 }
 }
 
 /// <summary>·
 /// A subtest for testing execute when an exception is thrown during sen
ding the request, with or without·
- /// back-off. If back-off handler is attached to the service's message h
 andler, there are going to be several·
- /// retries (up to 2 minutes).
+ /// back-off. If back-off handler is attached to the service's message h
 andler, there are going to be 3 tries·
+ /// (3 is the default value of <seealso cref="ConfigurableMessageHandler
 .NumTries" />) before the operation·
+ /// fails.
 /// </summary>
 /// <param name="backOff">Indicates if back-off handler is attached to t
he service.</param>
 private void SubtestExecute_ThrowException(bool backOff)
 {
 var handler = new MockMessageHandler(true);
 var initializer = new BaseClientService.Initializer()
 {
 HttpClientFactory = new MockHttpClientFactory(handler)
 };
 
- // by default back-off is used, so disable it in case backOff is fal
 se
- if (!backOff)
- {
- initializer.DefaultExponentialBackOffPolicy = BaseClientService.
 ExponentialBackOffPolicy.None;
- }
+ // sets the default exponential back-off policy by the input
+ initializer.DefaultExponentialBackOffPolicy = backOff ?
+ BaseClientService.ExponentialBackOffPolicy.Exception :
+ BaseClientService.ExponentialBackOffPolicy.None;
 
 using (var service = new MockClientService(initializer))
 {
 var request = new TestClientServiceRequest(service, "GET", null)
;
 Assert.Throws<InvalidOperationMockException>(() => request.Execu
te());
 
- // if back-off is enabled, we use 2 minutes maximum wait time fo
 r a request, so we should make lg(120)
- // 1 calls
- int calls = backOff ? (int)Math.Ceiling(Math.Log(120, 2) 1) : 
 1;
+ int calls = backOff ? service.HttpClient.MessageHandler.NumTries
  : 1;
 Assert.That(handler.Calls, Is.EqualTo(calls));
 }
 }
 
 /// <summary>·
 /// Tests execute when an exception is thrown during a request and expon
ential back-off is enabled.
 /// </summary>
 [Test]
 public void Execute_ThrowException_WithBackOff()
 {
 SubtestExecute_ThrowException(true);
 }
 
 /// <summary>·
 /// Tests execute when an exception is thrown during a request and expon
ential back-off is disabled.
 /// </summary>
 [Test]
 public void Execute_ThrowException_WithoutBackOff()
 {
 SubtestExecute_ThrowException(false);
 }
 
 /// <summary>·
 /// A subtest for testing async execute when an exception is thrown duri
ng sending the request, with or without·
- /// back-off handler. If back-off handler is attached to the service's m
 essage handler, there are going to be·
- /// several retries (up to 2 minutes).
+ /// back-off handler. If back-off handler is attached to the service's m
 essage handler, there are going to be 3
+ /// tries (3 is the default value of <seealso cref="ConfigurableMessageH
 andler.NumTries" />) before the·
+ /// operation fails.
 /// </summary>
 /// <param name="backOff">Indicates if back-off handler is attached to t
he service.</param>
 private void SubtestExecuteAsync_ThrowException(bool backOff)
 {
 var handler = new MockMessageHandler(true);
 var initializer = new BaseClientService.Initializer()
 {
 HttpClientFactory = new MockHttpClientFactory(handler)
 };
 
- // by default back-off is used, so disable it in case backOff is fal
 se
- if (!backOff)
- {
- initializer.DefaultExponentialBackOffPolicy = BaseClientService.
 ExponentialBackOffPolicy.None;
- }
+ // configure the back-off behavior by the input
+ initializer.DefaultExponentialBackOffPolicy = backOff ?
+ BaseClientService.ExponentialBackOffPolicy.Exception :
+ BaseClientService.ExponentialBackOffPolicy.None;
 
 using (var service = new MockClientService(initializer))
 {
 var request = new TestClientServiceRequest(service, "GET", null)
;
 var task = request.ExecuteAsync();
 try
 {
 var result = task.Result;
 Assert.Fail("Exception should be thrown");
 }
 catch (AggregateException ex)
 {
 Assert.That(ex.InnerException, Is.AssignableFrom(typeof(Inva
lidOperationMockException)));
 }
 
- // if back-off is enabled, we use 2 minutes maximum wait time fo
 r a request, so we should make lg(120)
- // 1 calls
- int calls = backOff ? (int)Math.Ceiling(Math.Log(120, 2) 1) : 
 1;
+ int calls = backOff ? service.HttpClient.MessageHandler.NumTries
  : 1;
 Assert.That(handler.Calls, Is.EqualTo(calls));
 }
 }
 
 /// <summary>·
 /// Tests async execute when an exception is thrown during a request and
exponential back-off is enabled.
 /// </summary>
 [Test]
 public void ExecuteAsync_ThrowException_WithBackOff()
 {
@@ skipping 481 matching lines @@
 Assert.AreEqual(ETagAction.IfMatch, ClientServiceRequest<object>.Get
DefaultETagAction(HttpConsts.Post));
 Assert.AreEqual(ETagAction.IfMatch, ClientServiceRequest<object>.Get
DefaultETagAction(HttpConsts.Patch));
 Assert.AreEqual(ETagAction.IfMatch, ClientServiceRequest<object>.Get
DefaultETagAction(HttpConsts.Put));
 Assert.AreEqual(ETagAction.IfMatch, ClientServiceRequest<object>.Get
DefaultETagAction(HttpConsts.Delete));
 Assert.AreEqual(ETagAction.Ignore, ClientServiceRequest<object>.GetD
efaultETagAction("INVALID"));
 }
 
 #endregion
 }
 }