Issue 369: Change default behavior of an HTTP request

Src/GoogleApis/Apis/Http/BackOffHandler.cs

 /*
 Copyright 2013 Google Inc
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
 http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
@@ skipping 22 matching lines @@
 
 /// <summary> An initializer class to initialize a back-off handler. </s
ummary>
 public class Initializer
 {
 /// <summary> Gets the back-off policy used by this back-off handler
. </summary>
 public IBackOff BackOff { get; private set; }
 
 /// <summary>·
 /// Gets or sets the maximum time span to wait. If the back-off inst
ance returns a greater time span then·
 /// this value, this handler returns <c>false</c> to both <see cref=
"HandleException"/> and·
- /// <see cref="HandleResponse"/>. Default value is 2 minutes per a r
 etry request.
+ /// <see cref="HandleResponse"/>. Default value is 5 seconds per a r
 etry request.
 /// </summary>
 public TimeSpan MaxTimeSpan { get; set; }
 
 /// <summary>·
 /// Gets or sets a delegate function which indicates if this back-of
f handler should handle an abnormal·
 /// Http response. The default is <see cref="DefaultHandleUnsuccessf
ulResponse"/>.·
 /// </summary>
 public Func<HttpResponseMessage, bool> HandleUnsuccessfulResponseFun
c { get; set; }
 
 /// <summary>·
 /// Gets or sets a delegate function which indicates if this back-of
f handler should handle an exception.·
 /// The default is <see cref="DefaultHandleException"/>.·
 /// </summary>
 public Func<Exception, bool> HandleExceptionFunc { get; set; }
 
- /// <summary> Default function which handles server errors (5xx). </
 summary>
+ /// <summary> Default function which handles server errors (503). </
 summary>
 public static readonly Func<HttpResponseMessage, bool> DefaultHandle
UnsuccessfulResponseFunc =
- (r) => (int)r.StatusCode / 100 == 5;
+ (r) => (int)r.StatusCode == 503;
 
 /// <summary>·
 /// Default function which handles exception which aren't·
 /// <seealso cref="System.Threading.Tasks.TaskCanceledException"/> o
r·
 /// <seealso cref="System.OperationCanceledException"/>. Those excep
tions represent a task or an operation
 /// which was canceled and we shouldn't retry.
 /// </summary>
 public static readonly Func<Exception, bool> DefaultHandleExceptionF
unc =
 (ex) => !(ex is TaskCanceledException || ex is OperationCanceled
Exception);
 
 /// <summary> Constructs a new initializer by the given back-off. </
summary>
 public Initializer(IBackOff backOff)
 {
 BackOff = backOff;
 HandleExceptionFunc = DefaultHandleExceptionFunc;
 HandleUnsuccessfulResponseFunc = DefaultHandleUnsuccessfulRespon
seFunc;
- MaxTimeSpan = TimeSpan.FromMinutes(2);
+ MaxTimeSpan = TimeSpan.FromSeconds(5);
 }
 }
 
 /// <summary> Gets the back-off policy used by this back-off handler. </
summary>
 public IBackOff BackOff { get; private set; }
 
 /// <summary>·
 /// Gets the maximum time span to wait. If the back-off instance returns
a greater time span, the handle method
- /// returns <c>false</c>. Default value is 2 minutes per a retry request
 .
+ /// returns <c>false</c>. Default value is 5 seconds per a retry request
 .
 /// </summary>
 public TimeSpan MaxTimeSpan { get; private set; }
 
 /// <summary>·
 /// Gets a delegate function which indicates if this back-off handler sh
ould handle an abnormal Http response.·
 /// The default is <see cref="DefaultHandleUnsuccessfulResponse"/>.·
 /// </summary>
 public Func<HttpResponseMessage, bool> HandleUnsuccessfulResponseFunc {
get; private set; }
 
 /// <summary>·
@@ skipping 70 matching lines @@
 protected virtual void Wait(TimeSpan ts, CancellationToken cancellationT
oken)
 {
 try
 {
 TaskEx.Delay(ts, cancellationToken).Wait();
 }
 catch (Exception) { }
 }
 }
 }